diff options
| author | Fam Zheng | 2018-03-15 04:45:07 +0100 |
|---|---|---|
| committer | Kevin Wolf | 2018-03-19 12:01:39 +0100 |
| commit | 4f8e3a1f225ea51707e2eec0aef5e8758b4d7e40 (patch) | |
| tree | bc9781bb8096729f7317e95c7807bb42103d927d /block | |
| parent | block/mirror: change the semantic of 'force' of block-job-cancel (diff) | |
| download | qemu-4f8e3a1f225ea51707e2eec0aef5e8758b4d7e40.tar.gz qemu-4f8e3a1f225ea51707e2eec0aef5e8758b4d7e40.tar.xz qemu-4f8e3a1f225ea51707e2eec0aef5e8758b4d7e40.zip | |
vvfat: Fix inherit_options flags
Overriding flags violates the precedence rules of
bdrv_reopen_queue_child. Just like the read-only option, no-flush should
be put into the options. The same is done in bdrv_temp_snapshot_options.
Reported-by: Stefan Hajnoczi <stefanha@redhat.com>
Signed-off-by: Fam Zheng <famz@redhat.com>
Reviewed-by: Eric Blake <eblake@redhat.com>
Reviewed-by: Stefan Hajnoczi <stefanha@redhat.com>
Signed-off-by: Kevin Wolf <kwolf@redhat.com>
Diffstat (limited to 'block')
| -rw-r--r-- | block/vvfat.c | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/block/vvfat.c b/block/vvfat.c index 4a17a49e12..1569783b0f 100644 --- a/block/vvfat.c +++ b/block/vvfat.c @@ -3129,7 +3129,7 @@ static void vvfat_qcow_options(int *child_flags, QDict *child_options, int parent_flags, QDict *parent_options) { qdict_set_default_str(child_options, BDRV_OPT_READ_ONLY, "off"); - *child_flags = BDRV_O_NO_FLUSH; + qdict_set_default_str(child_options, BDRV_OPT_CACHE_NO_FLUSH, "on"); } static const BdrvChildRole child_vvfat_qcow = { |