diff options
| author | Philippe Mathieu-Daudé | 2020-10-29 10:33:05 +0100 |
|---|---|---|
| committer | Stefan Hajnoczi | 2020-11-03 20:06:22 +0100 |
| commit | a0546a7b6f14a919b67cea1d1fc4362ac2901868 (patch) | |
| tree | 361d643217fd19800cf706fdb4ae344c881986ce /block | |
| parent | block/nvme: Fix use of write-only doorbells page on Aarch64 arch (diff) | |
| download | qemu-a0546a7b6f14a919b67cea1d1fc4362ac2901868.tar.gz qemu-a0546a7b6f14a919b67cea1d1fc4362ac2901868.tar.xz qemu-a0546a7b6f14a919b67cea1d1fc4362ac2901868.zip | |
block/nvme: Fix nvme_submit_command() on big-endian host
The Completion Queue Command Identifier is a 16-bit value,
so nvme_submit_command() is unlikely to work on big-endian
hosts, as the relevant bits are truncated.
Fix by using the correct byte-swap function.
Fixes: bdd6a90a9e5 ("block: Add VFIO based NVMe driver")
Reported-by: Keith Busch <kbusch@kernel.org>
Signed-off-by: Philippe Mathieu-Daudé <philmd@redhat.com>
Reviewed-by: Stefan Hajnoczi <stefanha@redhat.com>
Message-id: 20201029093306.1063879-25-philmd@redhat.com
Signed-off-by: Stefan Hajnoczi <stefanha@redhat.com>
Tested-by: Eric Auger <eric.auger@redhat.com>
Diffstat (limited to 'block')
| -rw-r--r-- | block/nvme.c | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/block/nvme.c b/block/nvme.c index c8ef69cbb2..a06a188d53 100644 --- a/block/nvme.c +++ b/block/nvme.c @@ -469,7 +469,7 @@ static void nvme_submit_command(NVMeQueuePair *q, NVMeRequest *req, assert(!req->cb); req->cb = cb; req->opaque = opaque; - cmd->cid = cpu_to_le32(req->cid); + cmd->cid = cpu_to_le16(req->cid); trace_nvme_submit_command(q->s, q->index, req->cid); nvme_trace_command(cmd); |