diff options
| author | Peter Lieven | 2016-05-24 10:59:28 +0200 |
|---|---|---|
| committer | Paolo Bonzini | 2016-05-29 09:11:11 +0200 |
| commit | a6b3167fa0e825aebb5a7cd8b437b6d41584a196 (patch) | |
| tree | 4e412f75f232192971ae947302fa307eb509b4fc /block | |
| parent | scsi: megasas: check 'read_queue_head' index value (diff) | |
| download | qemu-a6b3167fa0e825aebb5a7cd8b437b6d41584a196.tar.gz qemu-a6b3167fa0e825aebb5a7cd8b437b6d41584a196.tar.xz qemu-a6b3167fa0e825aebb5a7cd8b437b6d41584a196.zip | |
block/iscsi: avoid potential overflow of acb->task->cdb
at least in the path via virtio-blk the maximum size is not
restricted.
Cc: qemu-stable@nongnu.org
Signed-off-by: Peter Lieven <pl@kamp.de>
Message-Id: <1464080368-29584-1-git-send-email-pl@kamp.de>
Signed-off-by: Paolo Bonzini <pbonzini@redhat.com>
Diffstat (limited to 'block')
| -rw-r--r-- | block/iscsi.c | 7 |
1 files changed, 7 insertions, 0 deletions
diff --git a/block/iscsi.c b/block/iscsi.c index 2ca8e72967..e7d5f7b0c3 100644 --- a/block/iscsi.c +++ b/block/iscsi.c @@ -833,6 +833,13 @@ static BlockAIOCB *iscsi_aio_ioctl(BlockDriverState *bs, return &acb->common; } + if (acb->ioh->cmd_len > SCSI_CDB_MAX_SIZE) { + error_report("iSCSI: ioctl error CDB exceeds max size (%d > %d)", + acb->ioh->cmd_len, SCSI_CDB_MAX_SIZE); + qemu_aio_unref(acb); + return NULL; + } + acb->task = malloc(sizeof(struct scsi_task)); if (acb->task == NULL) { error_report("iSCSI: Failed to allocate task for scsi command. %s", |