diff options
| author | Kevin Wolf | 2013-04-12 18:05:35 +0200 |
|---|---|---|
| committer | Kevin Wolf | 2013-04-22 10:27:59 +0200 |
| commit | a9ccedc3daa06723821663c6b3b02c1760035bb9 (patch) | |
| tree | ea4f0967d07288a2c937c0dbc282fffab20d6bc7 /block | |
| parent | iscsi: Use bdrv_open options instead of filename (diff) | |
| download | qemu-a9ccedc3daa06723821663c6b3b02c1760035bb9.tar.gz qemu-a9ccedc3daa06723821663c6b3b02c1760035bb9.tar.xz qemu-a9ccedc3daa06723821663c6b3b02c1760035bb9.zip | |
rbd: Use bdrv_open options instead of filename
This is only to convert the internal interface that is used for passing
the "filename" to be parsed, but converting to actual fine grained
options is left for another day, as it doesn't look trivial.
Signed-off-by: Kevin Wolf <kwolf@redhat.com>
Reviewed-by: Eric Blake <eblake@redhat.com>
Diffstat (limited to 'block')
| -rw-r--r-- | block/rbd.c | 31 |
1 files changed, 30 insertions, 1 deletions
diff --git a/block/rbd.c b/block/rbd.c index 141b488968..0d68145881 100644 --- a/block/rbd.c +++ b/block/rbd.c @@ -441,7 +441,21 @@ static int qemu_rbd_aio_flush_cb(void *opaque) return (s->qemu_aio_count > 0); } -static int qemu_rbd_open(BlockDriverState *bs, const char *filename, +/* TODO Convert to fine grained options */ +static QemuOptsList runtime_opts = { + .name = "rbd", + .head = QTAILQ_HEAD_INITIALIZER(runtime_opts.head), + .desc = { + { + .name = "filename", + .type = QEMU_OPT_STRING, + .help = "Specification of the rbd image", + }, + { /* end of list */ } + }, +}; + +static int qemu_rbd_open(BlockDriverState *bs, const char *dummy, QDict *options, int flags) { BDRVRBDState *s = bs->opaque; @@ -450,8 +464,23 @@ static int qemu_rbd_open(BlockDriverState *bs, const char *filename, char conf[RBD_MAX_CONF_SIZE]; char clientname_buf[RBD_MAX_CONF_SIZE]; char *clientname; + QemuOpts *opts; + Error *local_err = NULL; + const char *filename; int r; + opts = qemu_opts_create_nofail(&runtime_opts); + qemu_opts_absorb_qdict(opts, options, &local_err); + if (error_is_set(&local_err)) { + qerror_report_err(local_err); + error_free(local_err); + qemu_opts_del(opts); + return -EINVAL; + } + + filename = qemu_opt_get(opts, "filename"); + qemu_opts_del(opts); + if (qemu_rbd_parsename(filename, pool, sizeof(pool), snap_buf, sizeof(snap_buf), s->name, sizeof(s->name), |