diff options
| author | Nishanth Aravamudan | 2018-06-22 21:37:00 +0200 |
|---|---|---|
| committer | Stefan Hajnoczi | 2018-06-27 14:06:34 +0200 |
| commit | ed6e2161715c527330f936d44af4c547f25f687e (patch) | |
| tree | 691d9a8ffcf3b7b6fe520ad7c2e2b65b2bb67855 /chardev/char-socket.c | |
| parent | compiler: add a sizeof_field() macro (diff) | |
| download | qemu-ed6e2161715c527330f936d44af4c547f25f687e.tar.gz qemu-ed6e2161715c527330f936d44af4c547f25f687e.tar.xz qemu-ed6e2161715c527330f936d44af4c547f25f687e.zip | |
linux-aio: properly bubble up errors from initialization
laio_init() can fail for a couple of reasons, which will lead to a NULL
pointer dereference in laio_attach_aio_context().
To solve this, add a aio_setup_linux_aio() function which is called
early in raw_open_common. If this fails, propagate the error up. The
signature of aio_get_linux_aio() was not modified, because it seems
preferable to return the actual errno from the possible failing
initialization calls.
Additionally, when the AioContext changes, we need to associate a
LinuxAioState with the new AioContext. Use the bdrv_attach_aio_context
callback and call the new aio_setup_linux_aio(), which will allocate a
new AioContext if needed, and return errors on failures. If it fails for
any reason, fallback to threaded AIO with an error message, as the
device is already in-use by the guest.
Add an assert that aio_get_linux_aio() cannot return NULL.
Signed-off-by: Nishanth Aravamudan <naravamudan@digitalocean.com>
Message-id: 20180622193700.6523-1-naravamudan@digitalocean.com
Signed-off-by: Stefan Hajnoczi <stefanha@redhat.com>
Diffstat (limited to 'chardev/char-socket.c')
0 files changed, 0 insertions, 0 deletions