diff options
| author | Markus Armbruster | 2018-02-01 12:18:31 +0100 |
|---|---|---|
| committer | Markus Armbruster | 2018-02-09 13:50:17 +0100 |
| commit | e688df6bc4549f28534cdb001f168b8caae55b0c (patch) | |
| tree | d77cfea92ccc7318f7ac82b75a72821d06b5dc75 /chardev | |
| parent | Drop superfluous includes of qapi-types.h and test-qapi-types.h (diff) | |
| download | qemu-e688df6bc4549f28534cdb001f168b8caae55b0c.tar.gz qemu-e688df6bc4549f28534cdb001f168b8caae55b0c.tar.xz qemu-e688df6bc4549f28534cdb001f168b8caae55b0c.zip | |
Include qapi/error.h exactly where needed
This cleanup makes the number of objects depending on qapi/error.h
drop from 1910 (out of 4743) to 1612 in my "build everything" tree.
While there, separate #include from file comment with a blank line,
and drop a useless comment on why qemu/osdep.h is included first.
Reviewed-by: Eric Blake <eblake@redhat.com>
Reviewed-by: Philippe Mathieu-Daudé <f4bug@amsat.org>
Signed-off-by: Markus Armbruster <armbru@redhat.com>
Message-Id: <20180201111846.21846-5-armbru@redhat.com>
[Semantic conflict with commit 34e304e975 resolved, OSX breakage fixed]
Diffstat (limited to 'chardev')
| -rw-r--r-- | chardev/char-ringbuf.c | 2 | ||||
| -rw-r--r-- | chardev/char.c | 2 | ||||
| -rw-r--r-- | chardev/spice.c | 1 |
3 files changed, 5 insertions, 0 deletions
diff --git a/chardev/char-ringbuf.c b/chardev/char-ringbuf.c index df52b04d22..c1fa4c3f87 100644 --- a/chardev/char-ringbuf.c +++ b/chardev/char-ringbuf.c @@ -21,9 +21,11 @@ * OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR OTHER DEALINGS IN * THE SOFTWARE. */ + #include "qemu/osdep.h" #include "chardev/char.h" #include "qmp-commands.h" +#include "qapi/error.h" #include "qemu/base64.h" /* Ring buffer chardev */ diff --git a/chardev/char.c b/chardev/char.c index 3e14de1920..51f269796a 100644 --- a/chardev/char.c +++ b/chardev/char.c @@ -21,6 +21,7 @@ * OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR OTHER DEALINGS IN * THE SOFTWARE. */ + #include "qemu/osdep.h" #include "qemu/cutils.h" #include "monitor/monitor.h" @@ -30,6 +31,7 @@ #include "chardev/char.h" #include "qmp-commands.h" #include "qapi-visit.h" +#include "qapi/error.h" #include "sysemu/replay.h" #include "qemu/help_option.h" diff --git a/chardev/spice.c b/chardev/spice.c index a312078812..bbdf649904 100644 --- a/chardev/spice.c +++ b/chardev/spice.c @@ -2,6 +2,7 @@ #include "trace.h" #include "ui/qemu-spice.h" #include "chardev/char.h" +#include "qapi/error.h" #include "qemu/error-report.h" #include <spice.h> #include <spice/protocol.h> |