summaryrefslogtreecommitdiffstats
path: root/configure
diff options
context:
space:
mode:
authorStefan Weil2011-09-04 18:30:02 +0200
committerStefan Hajnoczi2011-09-09 10:43:18 +0200
commitaf2d37de72ea67fddad0d51f5f81d7d7d54fd03a (patch)
treea102fa1454ba35dd5567fb2e39b46b895acdea4c /configure
parentqemu-options: Improve help texts for options which depend on configure (diff)
downloadqemu-af2d37de72ea67fddad0d51f5f81d7d7d54fd03a.tar.gz
qemu-af2d37de72ea67fddad0d51f5f81d7d7d54fd03a.tar.xz
qemu-af2d37de72ea67fddad0d51f5f81d7d7d54fd03a.zip
configure: Avoid duplicate flags when calling compile_prog
This patch removes redundant shell code and cleans it a little bit. Shell macro compile_prog takes two arguments: local_cflags and local ldflags. $QEMU_CFLAGS is added automatically to the cflags, so there is no need to pass it as an argument. It is also unnecessary to pass -Werror twice. $flag is a compiler warning option, so it should be in local_cflags instead of local_ldflags. Signed-off-by: Stefan Weil <weil@mail.berlios.de> Signed-off-by: Stefan Hajnoczi <stefanha@linux.vnet.ibm.com>
Diffstat (limited to 'configure')
-rwxr-xr-xconfigure2
1 files changed, 1 insertions, 1 deletions
diff --git a/configure b/configure
index f808f48fd3..348f36ae18 100755
--- a/configure
+++ b/configure
@@ -1070,7 +1070,7 @@ cat > $TMPC << EOF
int main(void) { return 0; }
EOF
for flag in $gcc_flags; do
- if compile_prog "-Werror $QEMU_CFLAGS" "-Werror $flag" ; then
+ if compile_prog "$flag -Werror" "" ; then
QEMU_CFLAGS="$QEMU_CFLAGS $flag"
fi
done