diff options
| author | Stefan Hajnoczi | 2020-11-18 10:16:42 +0100 |
|---|---|---|
| committer | Michael S. Tsirkin | 2020-12-09 19:04:17 +0100 |
| commit | fa77464ffe14be9532b861b33f57f5c1d63a4824 (patch) | |
| tree | 12cedb712d6409e24706ed8864566b883e4a2e5a /contrib/vhost-user-gpu | |
| parent | contrib/vhost-user-blk: avoid g_return_val_if() input validation (diff) | |
| download | qemu-fa77464ffe14be9532b861b33f57f5c1d63a4824.tar.gz qemu-fa77464ffe14be9532b861b33f57f5c1d63a4824.tar.xz qemu-fa77464ffe14be9532b861b33f57f5c1d63a4824.zip | |
contrib/vhost-user-gpu: avoid g_return_val_if() input validation
Do not validate input with g_return_val_if(). This API is intended for
checking programming errors and is compiled out with -DG_DISABLE_CHECKS.
Use an explicit if statement for input validation so it cannot
accidentally be compiled out.
Suggested-by: Markus Armbruster <armbru@redhat.com>
Signed-off-by: Stefan Hajnoczi <stefanha@redhat.com>
Message-Id: <20201118091644.199527-3-stefanha@redhat.com>
Reviewed-by: Michael S. Tsirkin <mst@redhat.com>
Signed-off-by: Michael S. Tsirkin <mst@redhat.com>
Diffstat (limited to 'contrib/vhost-user-gpu')
| -rw-r--r-- | contrib/vhost-user-gpu/vhost-user-gpu.c | 4 |
1 files changed, 3 insertions, 1 deletions
diff --git a/contrib/vhost-user-gpu/vhost-user-gpu.c b/contrib/vhost-user-gpu/vhost-user-gpu.c index a019d0a9ac..f445ef28ec 100644 --- a/contrib/vhost-user-gpu/vhost-user-gpu.c +++ b/contrib/vhost-user-gpu/vhost-user-gpu.c @@ -1044,7 +1044,9 @@ vg_get_config(VuDev *dev, uint8_t *config, uint32_t len) { VuGpu *g = container_of(dev, VuGpu, dev.parent); - g_return_val_if_fail(len <= sizeof(struct virtio_gpu_config), -1); + if (len > sizeof(struct virtio_gpu_config)) { + return -1; + } if (opt_virgl) { g->virtio_config.num_capsets = vg_virgl_get_num_capsets(); |