diff options
| author | Gerd Hoffmann | 2021-06-04 12:37:14 +0200 |
|---|---|---|
| committer | Gerd Hoffmann | 2021-06-15 07:16:25 +0200 |
| commit | 25b2ef2e8ee23109b0c3ce9ea71330bf8a7d12bd (patch) | |
| tree | 8f62e8deead182314f100e269e851aadeb47d479 /contrib | |
| parent | vga: Allow writing VBE_DISPI_ID5 to ID register (diff) | |
| download | qemu-25b2ef2e8ee23109b0c3ce9ea71330bf8a7d12bd.tar.gz qemu-25b2ef2e8ee23109b0c3ce9ea71330bf8a7d12bd.tar.xz qemu-25b2ef2e8ee23109b0c3ce9ea71330bf8a7d12bd.zip | |
vhost-user-gpu: reorder free calls.
Free in correct order to avoid use-after-free.
Resolves: CID 1453812
Signed-off-by: Gerd Hoffmann <kraxel@redhat.com>
Reviewed-by: Marc-André Lureau <marcandre.lureau@redhat.com>
Reviewed-by: Li Qiang <liq3ea@gmail.com>
Reviewed-by: Philippe Mathieu-Daudé <philmd@redhat.com>
Message-Id: <20210604103714.1237414-1-kraxel@redhat.com>
Diffstat (limited to 'contrib')
| -rw-r--r-- | contrib/vhost-user-gpu/vhost-user-gpu.c | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/contrib/vhost-user-gpu/vhost-user-gpu.c b/contrib/vhost-user-gpu/vhost-user-gpu.c index 6dc6a44f4e..611360e6b4 100644 --- a/contrib/vhost-user-gpu/vhost-user-gpu.c +++ b/contrib/vhost-user-gpu/vhost-user-gpu.c @@ -350,8 +350,8 @@ vg_resource_create_2d(VuGpu *g, if (!res->image) { g_critical("%s: resource creation failed %d %d %d", __func__, c2d.resource_id, c2d.width, c2d.height); - g_free(res); vugbm_buffer_destroy(&res->buffer); + g_free(res); cmd->error = VIRTIO_GPU_RESP_ERR_OUT_OF_MEMORY; return; } |