diff options
| author | Alex Chen | 2020-11-10 20:23:08 +0100 |
|---|---|---|
| committer | Alex Bennée | 2020-11-16 12:07:37 +0100 |
| commit | 9cd7dde0730ed823b545910c0d5a676142015e3b (patch) | |
| tree | fa518ff4b8cebe978044e5d027c38a4154181656 /contrib | |
| parent | plugins: Fix resource leak in connect_socket() (diff) | |
| download | qemu-9cd7dde0730ed823b545910c0d5a676142015e3b.tar.gz qemu-9cd7dde0730ed823b545910c0d5a676142015e3b.tar.xz qemu-9cd7dde0730ed823b545910c0d5a676142015e3b.zip | |
plugins: Fix two resource leaks in setup_socket()
Either accept() fails or exits normally, we need to close the fd.
Reported-by: Euler Robot <euler.robot@huawei.com>
Signed-off-by: Alex Chen <alex.chen@huawei.com>
Signed-off-by: Alex Bennée <alex.bennee@linaro.org>
Message-Id: <20201109082829.87496-3-alex.chen@huawei.com>
Message-Id: <20201110192316.26397-3-alex.bennee@linaro.org>
Diffstat (limited to 'contrib')
| -rw-r--r-- | contrib/plugins/lockstep.c | 2 |
1 files changed, 2 insertions, 0 deletions
diff --git a/contrib/plugins/lockstep.c b/contrib/plugins/lockstep.c index 319bd44b83..5aad50869d 100644 --- a/contrib/plugins/lockstep.c +++ b/contrib/plugins/lockstep.c @@ -268,11 +268,13 @@ static bool setup_socket(const char *path) socket_fd = accept(fd, NULL, NULL); if (socket_fd < 0 && errno != EINTR) { perror("accept socket"); + close(fd); return false; } qemu_plugin_outs("setup_socket::ready\n"); + close(fd); return true; } |