diff options
| author | Halil Pasic | 2020-03-09 14:32:23 +0100 |
|---|---|---|
| committer | Christian Borntraeger | 2020-03-10 10:18:14 +0100 |
| commit | 0a01e082a428b921e48b5314881b1f23a7b0fe50 (patch) | |
| tree | 1345659d6471f0e14680609470a8ad587366df04 /disas | |
| parent | s390x/bios: rebuild s390-ccw.img (diff) | |
| download | qemu-0a01e082a428b921e48b5314881b1f23a7b0fe50.tar.gz qemu-0a01e082a428b921e48b5314881b1f23a7b0fe50.tar.xz qemu-0a01e082a428b921e48b5314881b1f23a7b0fe50.zip | |
s390/ipl: sync back loadparm
We expose loadparm as a r/w machine property, but if loadparm is set by
the guest via DIAG 308, we don't update the property. Having a
disconnect between the guest view and the QEMU property is not nice in
itself, but things get even worse for SCSI, where under certain
circumstances (see 789b5a401b "s390: Ensure IPL from SCSI works as
expected" for details) we call s390_gen_initial_iplb() on resets
effectively overwriting the guest/user supplied loadparm with the stale
value.
Signed-off-by: Halil Pasic <pasic@linux.ibm.com>
Fixes: 7104bae9de ("hw/s390x: provide loadparm property for the machine")
Reported-by: Marc Hartmayer <mhartmay@linux.ibm.com>
Reviewed-by: Janosch Frank <frankja@linux.ibm.com>
Reviewed-by: Viktor Mihajlovski <mihajlov@linux.ibm.com>
Tested-by: Marc Hartmayer <mhartmay@linux.ibm.com>
Reviewed-by: David Hildenbrand <david@redhat.com>
Message-Id: <20200309133223.100491-1-pasic@linux.ibm.com>
[borntraeger@de.ibm.com: use reverse xmas tree]
Signed-off-by: Christian Borntraeger <borntraeger@de.ibm.com>
Diffstat (limited to 'disas')
0 files changed, 0 insertions, 0 deletions