diff options
| author | Daniel P. Berrangé | 2022-01-05 13:38:47 +0100 |
|---|---|---|
| committer | Kevin Wolf | 2022-01-14 12:03:16 +0100 |
| commit | 64b4529a432507ee84a924be69a03432639e87ba (patch) | |
| tree | a90711d418068a65a06f81cb356817c64cecd5a9 /docs | |
| parent | include/sysemu/blockdev.h: remove drive_get_max_devs (diff) | |
| download | qemu-64b4529a432507ee84a924be69a03432639e87ba.tar.gz qemu-64b4529a432507ee84a924be69a03432639e87ba.tar.xz qemu-64b4529a432507ee84a924be69a03432639e87ba.zip | |
softmmu: fix device deletion events with -device JSON syntax
The -device JSON syntax impl leaks a reference on the created
DeviceState instance. As a result when you hot-unplug the
device, the device_finalize method won't be called and thus
it will fail to emit the required DEVICE_DELETED event.
A 'json-cli' feature was previously added against the
'device_add' QMP command QAPI schema to indicated to mgmt
apps that -device supported JSON syntax. Given the hotplug
bug that feature flag is not usable for its purpose, so
we add a new 'json-cli-hotplug' feature to indicate the
-device supports JSON without breaking hotplug.
Fixes: 5dacda5167560b3af8eadbce5814f60ba44b467e
Resolves: https://gitlab.com/qemu-project/qemu/-/issues/802
Signed-off-by: Daniel P. Berrangé <berrange@redhat.com>
Message-Id: <20220105123847.4047954-2-berrange@redhat.com>
Reviewed-by: Laurent Vivier <lvivier@redhat.com>
Tested-by: Ján Tomko <jtomko@redhat.com>
Reviewed-by: Thomas Huth <thuth@redhat.com>
Signed-off-by: Kevin Wolf <kwolf@redhat.com>
Diffstat (limited to 'docs')
0 files changed, 0 insertions, 0 deletions