summaryrefslogtreecommitdiffstats
path: root/dump.c
diff options
context:
space:
mode:
authorPeter Maydell2017-09-14 17:33:02 +0200
committerPeter Maydell2017-09-14 17:33:02 +0200
commit3dabde1128b671f36ac6cb36b97b273139964420 (patch)
tree82425e1bc40064e994dd0c342773e3d8607285e5 /dump.c
parentMerge remote-tracking branch 'remotes/kraxel/tags/usb-20170913-pull-request' ... (diff)
parenthmp: introduce 'info memory_size_summary' command (diff)
downloadqemu-3dabde1128b671f36ac6cb36b97b273139964420.tar.gz
qemu-3dabde1128b671f36ac6cb36b97b273139964420.tar.xz
qemu-3dabde1128b671f36ac6cb36b97b273139964420.zip
Merge remote-tracking branch 'remotes/dgilbert/tags/pull-hmp-20170914' into staging
HMP pull 2017-09-14 # gpg: Signature made Thu 14 Sep 2017 15:57:30 BST # gpg: using RSA key 0x0516331EBC5BFDE7 # gpg: Good signature from "Dr. David Alan Gilbert (RH2) <dgilbert@redhat.com>" # gpg: WARNING: This key is not certified with sufficiently trusted signatures! # gpg: It is not certain that the signature belongs to the owner. # Primary key fingerprint: 45F5 C71B 4A0C B7FB 977A 9FA9 0516 331E BC5B FDE7 * remotes/dgilbert/tags/pull-hmp-20170914: hmp: introduce 'info memory_size_summary' command qmp: introduce query-memory-size-summary command hmp: extend "info numa" with hotplugged memory information tests/hmp: test "none" machine with memory dump: do not dump non-existent guest memory hmp: fix "dump-quest-memory" segfault (arm) hmp: fix "dump-quest-memory" segfault (ppc) Signed-off-by: Peter Maydell <peter.maydell@linaro.org>
Diffstat (limited to 'dump.c')
-rw-r--r--dump.c6
1 files changed, 6 insertions, 0 deletions
diff --git a/dump.c b/dump.c
index a79773d0f7..d2093e141b 100644
--- a/dump.c
+++ b/dump.c
@@ -1536,6 +1536,12 @@ static void dump_init(DumpState *s, int fd, bool has_format,
fprintf(stderr, "DUMP: total memory to dump: %lu\n", s->total_size);
#endif
+ /* it does not make sense to dump non-existent memory */
+ if (!s->total_size) {
+ error_setg(errp, "dump: no guest memory to dump");
+ goto cleanup;
+ }
+
s->start = get_start_block(s);
if (s->start == -1) {
error_setg(errp, QERR_INVALID_PARAMETER, "begin");