diff options
| author | Markus Armbruster | 2014-04-25 12:44:23 +0200 |
|---|---|---|
| committer | Andreas Färber | 2014-05-05 19:08:49 +0200 |
| commit | 0175ba109eb0c098a00903887328393c2e17d4ae (patch) | |
| tree | 400ba5c96ecc4d7b21c0dc1fd013b28f0554d608 /fpu | |
| parent | qom: Clean up fragile use of error_is_set() in set() methods (diff) | |
| download | qemu-0175ba109eb0c098a00903887328393c2e17d4ae.tar.gz qemu-0175ba109eb0c098a00903887328393c2e17d4ae.tar.xz qemu-0175ba109eb0c098a00903887328393c2e17d4ae.zip | |
arm: Clean up fragile use of error_is_set() in realize() methods
Using error_is_set(ERRP) to find out whether a function failed is
either wrong, fragile, or unnecessarily opaque. It's wrong when ERRP
may be null, because errors go undetected when it is. It's fragile
when proving ERRP non-null involves a non-local argument. Else, it's
unnecessarily opaque (see commit 84d18f0).
I guess the error_is_set(errp) in the DeviceClass realize() methods
are merely fragile right now, because I can't find a call chain that
passes a null errp argument.
Make the code more robust and more obviously correct: receive the
error in a local variable, then propagate it through the parameter.
Signed-off-by: Markus Armbruster <armbru@redhat.com>
Acked-by: Peter Maydell <peter.maydell@linaro.org>
Signed-off-by: Andreas Färber <afaerber@suse.de>
Diffstat (limited to 'fpu')
0 files changed, 0 insertions, 0 deletions