summaryrefslogtreecommitdiffstats
path: root/fsdev
diff options
context:
space:
mode:
authorManos Pitsidianakis2017-07-02 12:06:46 +0200
committerKevin Wolf2017-07-18 15:14:35 +0200
commit27e4cf13030ca5d12bbad12f38a27d35378a5894 (patch)
treed4b44b55555db9f98fb3446c74a53593feeb09f5 /fsdev
parentblock: add clock_type field to ThrottleGroup (diff)
downloadqemu-27e4cf13030ca5d12bbad12f38a27d35378a5894.tar.gz
qemu-27e4cf13030ca5d12bbad12f38a27d35378a5894.tar.xz
qemu-27e4cf13030ca5d12bbad12f38a27d35378a5894.zip
block: remove timer canceling in throttle_config()
throttle_config() cancels the timers of the calling BlockBackend. This doesn't make sense because other BlockBackends in the group remain untouched. There's no need to cancel the timers in the one specific BlockBackend so let's not do that. Throttled requests will run as scheduled and future requests will follow the new configuration. This also allows a throttle group's configuration to be changed even when it has no members. Signed-off-by: Manos Pitsidianakis <el13635@mail.ntua.gr> Reviewed-by: Stefan Hajnoczi <stefanha@redhat.com> Signed-off-by: Kevin Wolf <kwolf@redhat.com>
Diffstat (limited to 'fsdev')
-rw-r--r--fsdev/qemu-fsdev-throttle.c2
1 files changed, 1 insertions, 1 deletions
diff --git a/fsdev/qemu-fsdev-throttle.c b/fsdev/qemu-fsdev-throttle.c
index 453fb1efde..49eebb5412 100644
--- a/fsdev/qemu-fsdev-throttle.c
+++ b/fsdev/qemu-fsdev-throttle.c
@@ -86,7 +86,7 @@ void fsdev_throttle_init(FsThrottle *fst)
fsdev_throttle_read_timer_cb,
fsdev_throttle_write_timer_cb,
fst);
- throttle_config(&fst->ts, QEMU_CLOCK_REALTIME, &fst->tt, &fst->cfg);
+ throttle_config(&fst->ts, QEMU_CLOCK_REALTIME, &fst->cfg);
qemu_co_queue_init(&fst->throttled_reqs[0]);
qemu_co_queue_init(&fst->throttled_reqs[1]);
}