diff options
| author | John Snow | 2019-02-19 23:49:43 +0100 |
|---|---|---|
| committer | John Snow | 2019-02-19 23:49:43 +0100 |
| commit | 0a6c86d024c52b1e66d4f7ec01a3bb8ea2600145 (patch) | |
| tree | 535e448c0735275c2bccfc820ad6994bf0d41351 /hmp-commands.hx | |
| parent | block/dirty-bitmap: Documentation and Comment fixups (diff) | |
| download | qemu-0a6c86d024c52b1e66d4f7ec01a3bb8ea2600145.tar.gz qemu-0a6c86d024c52b1e66d4f7ec01a3bb8ea2600145.tar.xz qemu-0a6c86d024c52b1e66d4f7ec01a3bb8ea2600145.zip | |
blockdev: acquire aio_context for bitmap add/remove
When bitmaps are persistent, they may incur a disk read or write when bitmaps
are added or removed. For configurations like virtio-dataplane, failing to
acquire this lock will abort QEMU when disk IO occurs.
We used to acquire aio_context as part of the bitmap lookup, so re-introduce
the lock for just the cases that have an IO penalty. Commit 2119882c removed
these locks, and I failed to notice this when we committed fd5ae4cc, so this
has been broken since persistent bitmaps were introduced.
Fixes: https://bugzilla.redhat.com/show_bug.cgi?id=1672010
Reported-By: Aihua Liang <aliang@redhat.com>
Signed-off-by: John Snow <jsnow@redhat.com>
Reviewed-by: Eric Blake <eblake@redhat.com>
Message-id: 20190218233154.19303-1-jsnow@redhat.com
Signed-off-by: John Snow <jsnow@redhat.com>
Diffstat (limited to 'hmp-commands.hx')
0 files changed, 0 insertions, 0 deletions