diff options
| author | David Hildenbrand | 2020-06-10 09:51:53 +0200 |
|---|---|---|
| committer | Dr. David Alan Gilbert | 2020-06-17 18:48:39 +0200 |
| commit | 2d9e3dd9be1de3bbdca113673084dd19a8d957c3 (patch) | |
| tree | 7d7e15f202c716472d51d43313f3ca039e82b054 /hmp-commands.hx | |
| parent | qom-hmp-cmds: fix a memleak in hmp_qom_get (diff) | |
| download | qemu-2d9e3dd9be1de3bbdca113673084dd19a8d957c3.tar.gz qemu-2d9e3dd9be1de3bbdca113673084dd19a8d957c3.tar.xz qemu-2d9e3dd9be1de3bbdca113673084dd19a8d957c3.zip | |
hmp: Make json format optional for qom-set
Commit 7d2ef6dcc1cf ("hmp: Simplify qom-set") switched to the json
parser, making it possible to specify complex types. However, with this
change it is no longer possible to specify proper sizes (e.g., 2G, 128M),
turning the interface harder to use for properties that consume sizes.
Let's switch back to the previous handling and allow to specify passing
json via the "-j" parameter.
Cc: Philippe Mathieu-Daudé <philmd@redhat.com>
Cc: Markus Armbruster <armbru@redhat.com>
Cc: Dr. David Alan Gilbert <dgilbert@redhat.com>
Cc: Paolo Bonzini <pbonzini@redhat.com>
Cc: "Daniel P. Berrangé" <berrange@redhat.com>
Cc: Eduardo Habkost <ehabkost@redhat.com>
Signed-off-by: David Hildenbrand <david@redhat.com>
Message-Id: <20200610075153.33892-1-david@redhat.com>
Reviewed-by: Dr. David Alan Gilbert <dgilbert@redhat.com>
Signed-off-by: Dr. David Alan Gilbert <dgilbert@redhat.com>
Diffstat (limited to 'hmp-commands.hx')
| -rw-r--r-- | hmp-commands.hx | 7 |
1 files changed, 4 insertions, 3 deletions
diff --git a/hmp-commands.hx b/hmp-commands.hx index 28256209b5..60f395c276 100644 --- a/hmp-commands.hx +++ b/hmp-commands.hx @@ -1806,9 +1806,10 @@ ERST { .name = "qom-set", - .args_type = "path:s,property:s,value:S", - .params = "path property value", - .help = "set QOM property", + .args_type = "json:-j,path:s,property:s,value:S", + .params = "[-j] path property value", + .help = "set QOM property.\n\t\t\t" + "-j: the value is specified in json format.", .cmd = hmp_qom_set, .flags = "p", }, |