diff options
| author | Andreas Färber | 2013-08-01 01:59:47 +0200 |
|---|---|---|
| committer | Anthony Liguori | 2013-08-01 18:18:24 +0200 |
| commit | 27915efb974999dd256a6c432a17432d9d84e606 (patch) | |
| tree | 48beacbead44bf35e5492ce19a96bb2bfeb65584 /hw/9pfs/virtio-9p-device.c | |
| parent | Merge remote-tracking branch 'luiz/queue/qmp' into staging (diff) | |
| download | qemu-27915efb974999dd256a6c432a17432d9d84e606.tar.gz qemu-27915efb974999dd256a6c432a17432d9d84e606.tar.xz qemu-27915efb974999dd256a6c432a17432d9d84e606.zip | |
virtio-9p-device: Avoid freeing uninitialized memory
In virtio_9p_device_init() there are 6x goto out that will lead to
v9fs_path_free() attempting to free unitialized path.data field.
Easiest way to trigger is: qemu-system-x86_64 -device virtio-9p-pci
Fix this by moving v9fs_path_init() before any goto out.
Signed-off-by: Andreas Färber <afaerber@suse.de>
Signed-off-by: Andreas Färber <afaerber@suse.de>
Message-id: 1375315187-16534-1-git-send-email-afaerber@suse.de
Signed-off-by: Anthony Liguori <aliguori@us.ibm.com>
Diffstat (limited to 'hw/9pfs/virtio-9p-device.c')
| -rw-r--r-- | hw/9pfs/virtio-9p-device.c | 3 |
1 files changed, 2 insertions, 1 deletions
diff --git a/hw/9pfs/virtio-9p-device.c b/hw/9pfs/virtio-9p-device.c index de6f0fe290..f0ffbe8c0d 100644 --- a/hw/9pfs/virtio-9p-device.c +++ b/hw/9pfs/virtio-9p-device.c @@ -61,6 +61,8 @@ static int virtio_9p_device_init(VirtIODevice *vdev) s->vq = virtio_add_queue(vdev, MAX_REQ, handle_9p_output); + v9fs_path_init(&path); + fse = get_fsdev_fsentry(s->fsconf.fsdev_id); if (!fse) { @@ -111,7 +113,6 @@ static int virtio_9p_device_init(VirtIODevice *vdev) * call back to do that. Since we are in the init path, we don't * use co-routines here. */ - v9fs_path_init(&path); if (s->ops->name_to_path(&s->ctx, NULL, "/", &path) < 0) { fprintf(stderr, "error in converting name to path %s", strerror(errno)); |