diff options
| author | Peter Maydell | 2019-02-05 17:52:42 +0100 |
|---|---|---|
| committer | Peter Maydell | 2019-02-05 17:52:42 +0100 |
| commit | 2a5bdfc8d524535e78d81f5932fc62a6b34addc6 (patch) | |
| tree | 5224d94019c15331fb419733ca22f85244be0d8d /hw/arm | |
| parent | hw/arm/boot: Factor out "set up firmware boot" code (diff) | |
| download | qemu-2a5bdfc8d524535e78d81f5932fc62a6b34addc6.tar.gz qemu-2a5bdfc8d524535e78d81f5932fc62a6b34addc6.tar.xz qemu-2a5bdfc8d524535e78d81f5932fc62a6b34addc6.zip | |
hw/arm/boot: Clarify why arm_setup_firmware_boot() doesn't set env->boot_info
The code path for booting firmware doesn't set env->boot_info. At
first sight this looks odd, so add a comment saying why we don't.
Signed-off-by: Peter Maydell <peter.maydell@linaro.org>
Reviewed-by: Richard Henderson <richard.henderson@linaro.org>
Reviewed-by: Igor Mammedov <imammedo@redhat.com>
Message-id: 20190131112240.8395-5-peter.maydell@linaro.org
Diffstat (limited to 'hw/arm')
| -rw-r--r-- | hw/arm/boot.c | 3 |
1 files changed, 2 insertions, 1 deletions
diff --git a/hw/arm/boot.c b/hw/arm/boot.c index 2d4f710395..328cc6bd24 100644 --- a/hw/arm/boot.c +++ b/hw/arm/boot.c @@ -1182,7 +1182,8 @@ static void arm_setup_firmware_boot(ARMCPU *cpu, struct arm_boot_info *info) /* * We will start from address 0 (typically a boot ROM image) in the - * same way as hardware. + * same way as hardware. Leave env->boot_info NULL, so that + * do_cpu_reset() knows it does not need to alter the PC on reset. */ } |