diff options
| author | Philippe Mathieu-Daudé | 2020-11-02 17:52:16 +0100 |
|---|---|---|
| committer | Peter Maydell | 2020-11-02 17:52:16 +0100 |
| commit | 744a790ec01a30033309e6a2155df4d61061e184 (patch) | |
| tree | 668a161c5bca234db8fe5b4b347bd6ea1f79b331 /hw/arm | |
| parent | disas/capstone: Fix monitor disassembly of >32 bytes (diff) | |
| download | qemu-744a790ec01a30033309e6a2155df4d61061e184.tar.gz qemu-744a790ec01a30033309e6a2155df4d61061e184.tar.xz qemu-744a790ec01a30033309e6a2155df4d61061e184.zip | |
hw/arm/smmuv3: Fix potential integer overflow (CID 1432363)
Use the BIT_ULL() macro to ensure we use 64-bit arithmetic.
This fixes the following Coverity issue (OVERFLOW_BEFORE_WIDEN):
CID 1432363 (#1 of 1): Unintentional integer overflow:
overflow_before_widen:
Potentially overflowing expression 1 << scale with type int
(32 bits, signed) is evaluated using 32-bit arithmetic, and
then used in a context that expects an expression of type
hwaddr (64 bits, unsigned).
Signed-off-by: Philippe Mathieu-Daudé <philmd@redhat.com>
Acked-by: Eric Auger <eric.auger@redhat.com>
Message-id: 20201030144617.1535064-1-philmd@redhat.com
Reviewed-by: Peter Maydell <peter.maydell@linaro.org>
Signed-off-by: Peter Maydell <peter.maydell@linaro.org>
Diffstat (limited to 'hw/arm')
| -rw-r--r-- | hw/arm/smmuv3.c | 3 |
1 files changed, 2 insertions, 1 deletions
diff --git a/hw/arm/smmuv3.c b/hw/arm/smmuv3.c index 2017ba7a5a..22607c3784 100644 --- a/hw/arm/smmuv3.c +++ b/hw/arm/smmuv3.c @@ -17,6 +17,7 @@ */ #include "qemu/osdep.h" +#include "qemu/bitops.h" #include "hw/irq.h" #include "hw/sysbus.h" #include "migration/vmstate.h" @@ -864,7 +865,7 @@ static void smmuv3_s1_range_inval(SMMUState *s, Cmd *cmd) scale = CMD_SCALE(cmd); num = CMD_NUM(cmd); ttl = CMD_TTL(cmd); - num_pages = (num + 1) * (1 << (scale)); + num_pages = (num + 1) * BIT_ULL(scale); } if (type == SMMU_CMD_TLBI_NH_VA) { |