diff options
| author | Philippe Mathieu-Daudé | 2020-07-14 18:15:05 +0200 |
|---|---|---|
| committer | Philippe Mathieu-Daudé | 2020-07-21 16:13:04 +0200 |
| commit | 5e29521a82e540552880c3572cb8274bcaa1002c (patch) | |
| tree | 19dd0a6d4f09e86a6679506fac9230b125eac261 /hw/avr | |
| parent | qemu-common: Document qemu_find_file() (diff) | |
| download | qemu-5e29521a82e540552880c3572cb8274bcaa1002c.tar.gz qemu-5e29521a82e540552880c3572cb8274bcaa1002c.tar.xz qemu-5e29521a82e540552880c3572cb8274bcaa1002c.zip | |
hw/avr/boot: Fix memory leak in avr_load_firmware()
The value returned by qemu_find_file() must be freed.
This fixes Coverity issue CID 1430449, which points out
that the memory returned by qemu_find_file() is leaked.
Fixes: Coverity CID 1430449 (RESOURCE_LEAK)
Fixes: 7dd8f6fde4 ('hw/avr: Add support for loading ELF/raw binaries')
Signed-off-by: Philippe Mathieu-Daudé <f4bug@amsat.org>
Reviewed-by: Michael Rolnik <mrolnik@gmail.com>
Tested-by: Michael Rolnik <mrolnik@gmail.com>
Reviewed-by: Daniel P. Berrangé <berrange@redhat.com>
Message-Id: <20200714164257.23330-5-f4bug@amsat.org>
Diffstat (limited to 'hw/avr')
| -rw-r--r-- | hw/avr/boot.c | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/hw/avr/boot.c b/hw/avr/boot.c index 6fbcde4061..d16bb3dbe1 100644 --- a/hw/avr/boot.c +++ b/hw/avr/boot.c @@ -60,7 +60,7 @@ static const char *avr_elf_e_flags_to_cpu_type(uint32_t flags) bool avr_load_firmware(AVRCPU *cpu, MachineState *ms, MemoryRegion *program_mr, const char *firmware) { - const char *filename; + g_autofree char *filename = NULL; int bytes_loaded; uint64_t entry; uint32_t e_flags; |