diff options
| author | Alberto Faria | 2022-07-05 18:15:09 +0200 |
|---|---|---|
| committer | Hanna Reitz | 2022-07-12 12:14:56 +0200 |
| commit | bf5b16fa401633475d21d69c66532f5b29e8433d (patch) | |
| tree | 60779d913b400906135b6bbce90d6128a52ac3ef /hw/block | |
| parent | tests/qemu-iotests: skip 108 when FUSE is not loaded (diff) | |
| download | qemu-bf5b16fa401633475d21d69c66532f5b29e8433d.tar.gz qemu-bf5b16fa401633475d21d69c66532f5b29e8433d.tar.xz qemu-bf5b16fa401633475d21d69c66532f5b29e8433d.zip | |
block: Make blk_{pread,pwrite}() return 0 on success
They currently return the value of their 'bytes' parameter on success.
Make them return 0 instead, for consistency with other I/O functions and
in preparation to implement them using generated_co_wrapper. This also
makes it clear that short reads/writes are not possible.
Signed-off-by: Alberto Faria <afaria@redhat.com>
Message-Id: <20220705161527.1054072-2-afaria@redhat.com>
Reviewed-by: Hanna Reitz <hreitz@redhat.com>
Signed-off-by: Hanna Reitz <hreitz@redhat.com>
Diffstat (limited to 'hw/block')
| -rw-r--r-- | hw/block/m25p80.c | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/hw/block/m25p80.c b/hw/block/m25p80.c index 3045dda53b..755134313d 100644 --- a/hw/block/m25p80.c +++ b/hw/block/m25p80.c @@ -1532,7 +1532,7 @@ static void m25p80_realize(SSIPeripheral *ss, Error **errp) trace_m25p80_binding(s); s->storage = blk_blockalign(s->blk, s->size); - if (blk_pread(s->blk, 0, s->storage, s->size) != s->size) { + if (blk_pread(s->blk, 0, s->storage, s->size) < 0) { error_setg(errp, "failed to read the initial flash content"); return; } |