diff options
author | Eric Blake | 2018-12-15 14:53:10 +0100 |
---|---|---|
committer | Eric Blake | 2019-01-05 14:53:22 +0100 |
commit | ef2e35fcc8e14bcc9366df5fdf53f65d679f8dca (patch) | |
tree | 9566fc73deb06530ce8ef5207748ea2ba3c40f82 /hw/core/loader.c | |
parent | qemu-nbd: Fail earlier for -c/-d on non-linux (diff) | |
download | qemu-ef2e35fcc8e14bcc9366df5fdf53f65d679f8dca.tar.gz qemu-ef2e35fcc8e14bcc9366df5fdf53f65d679f8dca.tar.xz qemu-ef2e35fcc8e14bcc9366df5fdf53f65d679f8dca.zip |
nbd/client: Drop pointless buf variable
There's no need to read into a temporary buffer (oversized
since commit 7d3123e1) followed by a byteswap into a uint64_t
to check for a magic number via memcmp(), when the code
immediately below demonstrates reading into the uint64_t then
byteswapping in place and checking for a magic number via
integer math. What's more, having a different error message
when the server's first reply byte is 0 is unusual - it's no
different from any other wrong magic number, and we already
detected short reads. That whole strlen() issue has been
present and useless since commit 1d45f8b5 in 2010; perhaps it
was leftover debugging (since the correct magic number happens
to be ASCII)? Make the error messages more consistent and
detailed while touching things.
Signed-off-by: Eric Blake <eblake@redhat.com>
Reviewed-by: Richard W.M. Jones <rjones@redhat.com>
Reviewed-by: Vladimir Sementsov-Ogievskiy <vsementsov@virtuozzo.com>
Message-Id: <20181215135324.152629-9-eblake@redhat.com>
Diffstat (limited to 'hw/core/loader.c')
0 files changed, 0 insertions, 0 deletions