diff options
| author | Li Qiang | 2018-11-21 06:10:24 +0100 |
|---|---|---|
| committer | Philippe Mathieu-Daudé | 2019-01-04 15:30:52 +0100 |
| commit | 6912bb0b3d3b140c70d8cdfd2dff77f9890d7f12 (patch) | |
| tree | 631bab32fadff48185df0dff1d7e53923c8e770d /hw/core/qdev.c | |
| parent | fw_cfg: Improve error message when can't load splash file (diff) | |
| download | qemu-6912bb0b3d3b140c70d8cdfd2dff77f9890d7f12.tar.gz qemu-6912bb0b3d3b140c70d8cdfd2dff77f9890d7f12.tar.xz qemu-6912bb0b3d3b140c70d8cdfd2dff77f9890d7f12.zip | |
fw_cfg: Fix -boot bootsplash error checking
fw_cfg_bootsplash() gets option parameter "splash-time"
with qemu_opt_get(), then converts it to an integer by hand.
It neglects to check that conversion for errors. This is
needlessly complicated and error-prone. But as "splash-time
not specified" is not the same as "splash-time=T" for any T,
we need use qemu_opt_get() to check if splash time exists.
This patch also make the qemu exit when finding or loading
splash file failed.
Signed-off-by: Li Qiang <liq3ea@gmail.com>
Reviewed-by: Markus Armbruster <armbru@redhat.com>
Reviewed-by: Gerd Hoffmann <kraxel@redhat.com>
Reviewed-by: Philippe Mathieu-Daudé <philmd@redhat.com>
Message-Id: <1542777026-2788-2-git-send-email-liq3ea@gmail.com>
Signed-off-by: Philippe Mathieu-Daudé <philmd@redhat.com>
Diffstat (limited to 'hw/core/qdev.c')
0 files changed, 0 insertions, 0 deletions