diff options
| author | Greg Kurz | 2016-07-13 20:11:45 +0200 |
|---|---|---|
| committer | Eduardo Habkost | 2016-07-27 16:25:06 +0200 |
| commit | 78a3930685c3159c4b8f953bd9f9e7a28655d823 (patch) | |
| tree | 3bc90cd2f2dee714a0fb7ee3f7134b7a0b21f78d /hw/core | |
| parent | Revert "pc: Enforce adding CPUs contiguously and removing them in opposite or... (diff) | |
| download | qemu-78a3930685c3159c4b8f953bd9f9e7a28655d823.tar.gz qemu-78a3930685c3159c4b8f953bd9f9e7a28655d823.tar.xz qemu-78a3930685c3159c4b8f953bd9f9e7a28655d823.zip | |
machine: Add comment to abort path in machine_set_kernel_irqchip
We're not supposed to abort when the user passes a bogus value.
Since the checking is done in visit_type_OnOffSplit(), the call
to abort() is legitimate. Let's add a comment to make it
explicit.
Signed-off-by: Greg Kurz <groug@kaod.org>
Reviewed-by: Eduardo Habkost <ehabkost@redhat.com>
Signed-off-by: Eduardo Habkost <ehabkost@redhat.com>
Diffstat (limited to 'hw/core')
| -rw-r--r-- | hw/core/machine.c | 3 |
1 files changed, 3 insertions, 0 deletions
diff --git a/hw/core/machine.c b/hw/core/machine.c index 2fe6ff6f30..e5a456f21d 100644 --- a/hw/core/machine.c +++ b/hw/core/machine.c @@ -65,6 +65,9 @@ static void machine_set_kernel_irqchip(Object *obj, Visitor *v, ms->kernel_irqchip_split = true; break; default: + /* The value was checked in visit_type_OnOffSplit() above. If + * we get here, then something is wrong in QEMU. + */ abort(); } } |