diff options
| author | Jonathan Cameron | 2022-08-08 14:20:51 +0200 |
|---|---|---|
| committer | Michael S. Tsirkin | 2022-08-17 19:08:11 +0200 |
| commit | d2289b524e71970ea8ca5602f219cc92b8e5896b (patch) | |
| tree | 48fa641428d2e25a9e8a8449d572796ce8a3f428 /hw/cxl/cxl-device-utils.c | |
| parent | hw/cxl: Fix memory leak in error paths (diff) | |
| download | qemu-d2289b524e71970ea8ca5602f219cc92b8e5896b.tar.gz qemu-d2289b524e71970ea8ca5602f219cc92b8e5896b.tar.xz qemu-d2289b524e71970ea8ca5602f219cc92b8e5896b.zip | |
hw/cxl: Fix wrong query of target ports
Two issues were present in this code:
1) Check on which register to look in was inverted.
2) Both branches use the _LO register.
Whilst here moved to extract32() rather than hand rolling
the field extraction as simpler and hopefully less error prone.
Fixes Coverity CID: 1488873
Reported-by: Peter Maydell <peter.maydell@linaro.org>
Signed-off-by: Jonathan Cameron <Jonathan.Cameron@huawei.com>
Message-Id: <20220808122051.14822-3-Jonathan.Cameron@huawei.com>
Reviewed-by: Michael S. Tsirkin <mst@redhat.com>
Signed-off-by: Michael S. Tsirkin <mst@redhat.com>
Diffstat (limited to 'hw/cxl/cxl-device-utils.c')
0 files changed, 0 insertions, 0 deletions