summaryrefslogtreecommitdiffstats
path: root/hw/display/vmware_vga.c
diff options
context:
space:
mode:
authorGerd Hoffmann2014-10-06 11:42:34 +0200
committerGerd Hoffmann2014-10-28 10:39:58 +0100
commit83afa38eb20ca27e30683edc7729880e091387fc (patch)
treeae7e85d197e219506cbf0154ac3b807c09f050a7 /hw/display/vmware_vga.c
parentRevert "main-loop.c: Handle SIGINT, SIGHUP and SIGTERM synchronously" (diff)
downloadqemu-83afa38eb20ca27e30683edc7729880e091387fc.tar.gz
qemu-83afa38eb20ca27e30683edc7729880e091387fc.tar.xz
qemu-83afa38eb20ca27e30683edc7729880e091387fc.zip
vmware-vga: CVE-2014-3689: turn off hw accel
Quick & easy stopgap for CVE-2014-3689: We just compile out the hardware acceleration functions which lack sanity checks. Thankfully we have capability bits for them (SVGA_CAP_RECT_COPY and SVGA_CAP_RECT_FILL), so guests should deal just fine, in theory. Subsequent patches will add the missing checks and re-enable the hardware acceleration emulation. Cc: qemu-stable@nongnu.org Signed-off-by: Gerd Hoffmann <kraxel@redhat.com> Reviewed-by: Don Koch <dkoch@verizon.com>
Diffstat (limited to 'hw/display/vmware_vga.c')
-rw-r--r--hw/display/vmware_vga.c2
1 files changed, 2 insertions, 0 deletions
diff --git a/hw/display/vmware_vga.c b/hw/display/vmware_vga.c
index 0c36c7204f..ec63290a54 100644
--- a/hw/display/vmware_vga.c
+++ b/hw/display/vmware_vga.c
@@ -29,8 +29,10 @@
#include "hw/pci/pci.h"
#undef VERBOSE
+#if 0
#define HW_RECT_ACCEL
#define HW_FILL_ACCEL
+#endif
#define HW_MOUSE_ACCEL
#include "vga_int.h"