diff options
| author | Peter Maydell | 2018-10-08 15:55:05 +0200 |
|---|---|---|
| committer | Peter Maydell | 2018-10-08 15:55:05 +0200 |
| commit | 74e2e59b8d0a68be0956310fc349179c89fd7be0 (patch) | |
| tree | 2a3929c352b68589d0ee5d3b36573d93d9ae707e /hw/display/xenfb.c | |
| parent | target/arm: Add v8M stack checks for MSR to SP_NS (diff) | |
| download | qemu-74e2e59b8d0a68be0956310fc349179c89fd7be0.tar.gz qemu-74e2e59b8d0a68be0956310fc349179c89fd7be0.tar.xz qemu-74e2e59b8d0a68be0956310fc349179c89fd7be0.zip | |
hw/display/bcm2835_fb: Silence Coverity warning about multiply overflow
Coverity complains (CID 1395628) that the multiply in the calculation
of the framebuffer base is performed as 32x32 but then used in a
context that takes a 64-bit hwaddr. This can't actually ever
overflow the 32-bit result, because of the constraints placed on
the s->config values in bcm2835_fb_validate_config(). But we
can placate Coverity anyway, by explicitly casting one of the
inputs to a hwaddr, so the whole expression is calculated with
64-bit arithmetic.
Signed-off-by: Peter Maydell <peter.maydell@linaro.org>
Reviewed-by: Paolo Bonzini <pbonzini@redhat.com>
Message-id: 20181005133012.26490-1-peter.maydell@linaro.org
Diffstat (limited to 'hw/display/xenfb.c')
0 files changed, 0 insertions, 0 deletions