summaryrefslogtreecommitdiffstats
path: root/hw/display
diff options
context:
space:
mode:
authorSebastian Bauer2018-07-04 11:40:58 +0200
committerDavid Gibson2018-07-07 04:12:27 +0200
commit06cb926aaa51970fc009245bb5e15700c19a56f8 (patch)
tree76ca9b316c416606df8651795c0ff753efed0b4a /hw/display
parentsm501: Implement negated destination raster operation mode (diff)
downloadqemu-06cb926aaa51970fc009245bb5e15700c19a56f8.tar.gz
qemu-06cb926aaa51970fc009245bb5e15700c19a56f8.tar.xz
qemu-06cb926aaa51970fc009245bb5e15700c19a56f8.zip
sm501: Log unimplemented raster operation modes
The sm501 currently implements only a very limited set of raster operation modes. After this change, unknown raster operation modes are logged so these can be easily spotted. Signed-off-by: BALATON Zoltan <balaton@eik.bme.hu> Signed-off-by: David Gibson <david@gibson.dropbear.id.au>
Diffstat (limited to 'hw/display')
-rw-r--r--hw/display/sm501.c23
1 files changed, 23 insertions, 0 deletions
diff --git a/hw/display/sm501.c b/hw/display/sm501.c
index 0b44d95169..ebd139006e 100644
--- a/hw/display/sm501.c
+++ b/hw/display/sm501.c
@@ -706,6 +706,8 @@ static void sm501_2d_operation(SM501State *s)
int format_flags = (s->twoD_stretch >> 20) & 0x3;
int addressing = (s->twoD_stretch >> 16) & 0xF;
int rop_mode = (s->twoD_control >> 15) & 0x1; /* 1 for rop2, else rop3 */
+ /* 1 if rop2 source is the pattern, otherwise the source is the bitmap */
+ int rop2_source_is_pattern = (s->twoD_control >> 14) & 0x1;
int rop = s->twoD_control & 0xFF;
/* get frame buffer info */
@@ -719,6 +721,27 @@ static void sm501_2d_operation(SM501State *s)
abort();
}
+ if (rop_mode == 0) {
+ if (rop != 0xcc) {
+ /* Anything other than plain copies are not supported */
+ qemu_log_mask(LOG_UNIMP, "sm501: rop3 mode with rop %x is not "
+ "supported.\n", rop);
+ }
+ } else {
+ if (rop2_source_is_pattern && rop != 0x5) {
+ /* For pattern source, we support only inverse dest */
+ qemu_log_mask(LOG_UNIMP, "sm501: rop2 source being the pattern and "
+ "rop %x is not supported.\n", rop);
+ } else {
+ if (rop != 0x5 && rop != 0xc) {
+ /* Anything other than plain copies or inverse dest is not
+ * supported */
+ qemu_log_mask(LOG_UNIMP, "sm501: rop mode %x is not "
+ "supported.\n", rop);
+ }
+ }
+ }
+
if ((s->twoD_source_base & 0x08000000) ||
(s->twoD_destination_base & 0x08000000)) {
printf("%s: only local memory is supported.\n", __func__);