diff options
| author | Li Qiang | 2016-11-29 03:29:25 +0100 |
|---|---|---|
| committer | Gerd Hoffmann | 2017-01-03 15:47:16 +0100 |
| commit | b8e23926c568f2e963af39028b71c472e3023793 (patch) | |
| tree | b0609d9f7ccb775c8dae5ede4b5a29ae4a24349a /hw/display | |
| parent | virtio-gpu: track and limit host memory allocations (diff) | |
| download | qemu-b8e23926c568f2e963af39028b71c472e3023793.tar.gz qemu-b8e23926c568f2e963af39028b71c472e3023793.tar.xz qemu-b8e23926c568f2e963af39028b71c472e3023793.zip | |
virtio-gpu: call cleanup mapping function in resource destroy
If the guest destroy the resource before detach banking, the 'iov'
and 'addrs' field in resource is not freed thus leading memory
leak issue. This patch avoid this.
Signed-off-by: Li Qiang <liq3ea@gmail.com>
Reviewed-by: Marc-André Lureau <marcandre.lureau@redhat.com>
Message-id: 1480386565-10077-1-git-send-email-liq3ea@gmail.com
Signed-off-by: Gerd Hoffmann <kraxel@redhat.com>
Diffstat (limited to 'hw/display')
| -rw-r--r-- | hw/display/virtio-gpu.c | 3 |
1 files changed, 3 insertions, 0 deletions
diff --git a/hw/display/virtio-gpu.c b/hw/display/virtio-gpu.c index ed2b6d3deb..6a26258cac 100644 --- a/hw/display/virtio-gpu.c +++ b/hw/display/virtio-gpu.c @@ -28,6 +28,8 @@ static struct virtio_gpu_simple_resource* virtio_gpu_find_resource(VirtIOGPU *g, uint32_t resource_id); +static void virtio_gpu_cleanup_mapping(struct virtio_gpu_simple_resource *res); + #ifdef CONFIG_VIRGL #include <virglrenderer.h> #define VIRGL(_g, _virgl, _simple, ...) \ @@ -364,6 +366,7 @@ static void virtio_gpu_resource_destroy(VirtIOGPU *g, struct virtio_gpu_simple_resource *res) { pixman_image_unref(res->image); + virtio_gpu_cleanup_mapping(res); QTAILQ_REMOVE(&g->reslist, res, next); g->hostmem -= res->hostmem; g_free(res); |