diff options
author | Gerd Hoffmann | 2009-08-14 10:36:05 +0200 |
---|---|---|
committer | Anthony Liguori | 2009-08-28 03:43:28 +0200 |
commit | 81a322d4a1b68d47908a6630bf22897a289722aa (patch) | |
tree | cdca9840d0620d9e0b46d7b81c58abe04a372b78 /hw/i2c.h | |
parent | fix stack buffer overflows in eepro100.c tx (diff) | |
download | qemu-81a322d4a1b68d47908a6630bf22897a289722aa.tar.gz qemu-81a322d4a1b68d47908a6630bf22897a289722aa.tar.xz qemu-81a322d4a1b68d47908a6630bf22897a289722aa.zip |
qdev: add return value to init() callbacks.
Sorry folks, but it has to be. One more of these invasive qdev patches.
We have a serious design bug in the qdev interface: device init
callbacks can't signal failure because the init() callback has no
return value. This patch fixes it.
We have already one case in-tree where this is needed:
Try -device virtio-blk-pci (without drive= specified) and watch qemu
segfault. This patch fixes it.
With usb+scsi being converted to qdev we'll get more devices where the
init callback can fail for various reasons.
Signed-off-by: Gerd Hoffmann <kraxel@redhat.com>
Signed-off-by: Anthony Liguori <aliguori@us.ibm.com>
Diffstat (limited to 'hw/i2c.h')
-rw-r--r-- | hw/i2c.h | 2 |
1 files changed, 1 insertions, 1 deletions
@@ -22,7 +22,7 @@ typedef int (*i2c_recv_cb)(i2c_slave *s); /* Notify the slave of a bus state change. */ typedef void (*i2c_event_cb)(i2c_slave *s, enum i2c_event event); -typedef void (*i2c_slave_initfn)(i2c_slave *dev); +typedef int (*i2c_slave_initfn)(i2c_slave *dev); typedef struct { DeviceInfo qdev; |