summaryrefslogtreecommitdiffstats
path: root/hw/i386/Kconfig
diff options
context:
space:
mode:
authorPhilippe Mathieu-Daudé2019-12-31 19:32:05 +0100
committerPaolo Bonzini2020-01-07 12:08:39 +0100
commitff2efdcdc1674b31fcad64d668a4da01cd454b82 (patch)
tree671907b554749a3b6c4c70174451cee7689fe366 /hw/i386/Kconfig
parenthw/intc/i8259: Fix Kconfig dependency on ISA bus (diff)
downloadqemu-ff2efdcdc1674b31fcad64d668a4da01cd454b82.tar.gz
qemu-ff2efdcdc1674b31fcad64d668a4da01cd454b82.tar.xz
qemu-ff2efdcdc1674b31fcad64d668a4da01cd454b82.zip
hw/i386/Kconfig: Let the MicroVM machine select the SERIAL_ISA config
When configured with --without-default-devices, the build fails: LINK x86_64-softmmu/qemu-system-x86_64 /usr/bin/ld: hw/i386/microvm.o: in function `microvm_devices_init': hw/i386/microvm.c:157: undefined reference to `serial_hds_isa_init' collect2: error: ld returned 1 exit status make[1]: *** [Makefile:206: qemu-system-x86_64] Error 1 make: *** [Makefile:483: x86_64-softmmu/all] Error 2 While the MicroVM machine only uses the ISA serial port when the MICROVM_MACHINE_ISA_SERIAL property is set, it has to be linked with it. Replace the 'imply' Kconfig rule by a 'select'. Signed-off-by: Philippe Mathieu-Daudé <philmd@redhat.com> Message-Id: <20191231183216.6781-4-philmd@redhat.com> Signed-off-by: Paolo Bonzini <pbonzini@redhat.com>
Diffstat (limited to 'hw/i386/Kconfig')
-rw-r--r--hw/i386/Kconfig2
1 files changed, 1 insertions, 1 deletions
diff --git a/hw/i386/Kconfig b/hw/i386/Kconfig
index 91cf5843b4..cdc851598c 100644
--- a/hw/i386/Kconfig
+++ b/hw/i386/Kconfig
@@ -95,7 +95,7 @@ config Q35
config MICROVM
bool
- imply SERIAL_ISA
+ select SERIAL_ISA # for serial_hds_isa_init()
select ISA_BUS
select APIC
select IOAPIC