diff options
| author | Philippe Mathieu-Daudé | 2017-12-15 04:43:55 +0100 |
|---|---|---|
| committer | Paolo Bonzini | 2017-12-21 09:30:32 +0100 |
| commit | 7299e1a411de99761a4260e44b4f1cf2e4e126ef (patch) | |
| tree | ccd677f9ae21bf5c38bbabb3dde05fd9aee0d242 /hw/i386/vmport.c | |
| parent | hw/mips/boston: Remove workaround for writes to ROM aborting (diff) | |
| download | qemu-7299e1a411de99761a4260e44b4f1cf2e4e126ef.tar.gz qemu-7299e1a411de99761a4260e44b4f1cf2e4e126ef.tar.xz qemu-7299e1a411de99761a4260e44b4f1cf2e4e126ef.zip | |
hw/i386/vmport: replace fprintf() by trace events or LOG_UNIMP
Signed-off-by: Philippe Mathieu-Daudé <f4bug@amsat.org>
Message-Id: <20171215034356.4449-2-f4bug@amsat.org>
[Replace unknown command tracepoint with LOG_UNIMP, add
generic tracepoint for vmport commands. - Paolo]
Signed-off-by: Paolo Bonzini <pbonzini@redhat.com>
Diffstat (limited to 'hw/i386/vmport.c')
| -rw-r--r-- | hw/i386/vmport.c | 14 |
1 files changed, 5 insertions, 9 deletions
diff --git a/hw/i386/vmport.c b/hw/i386/vmport.c index eb880c6def..9b8c68806e 100644 --- a/hw/i386/vmport.c +++ b/hw/i386/vmport.c @@ -27,8 +27,7 @@ #include "hw/i386/pc.h" #include "sysemu/hw_accel.h" #include "hw/qdev.h" - -/* #define VMPORT_DEBUG */ +#include "trace.h" #define VMPORT_CMD_GETVERSION 0x0a #define VMPORT_CMD_GETRAMSIZE 0x14 @@ -54,6 +53,7 @@ void vmport_register(unsigned char command, VMPortReadFunc *func, void *opaque) return; } + trace_vmport_register(command, func, opaque); port_state->func[command] = func; port_state->opaque[command] = opaque; } @@ -76,13 +76,9 @@ static uint64_t vmport_ioport_read(void *opaque, hwaddr addr, } command = env->regs[R_ECX]; - if (command >= VMPORT_ENTRIES) { - return eax; - } - if (!s->func[command]) { -#ifdef VMPORT_DEBUG - fprintf(stderr, "vmport: unknown command %x\n", command); -#endif + trace_vmport_command(command); + if (command >= VMPORT_ENTRIES || !s->func[command]) { + qemu_log_mask(LOG_UNIMP, "vmport: unknown command %x\n", command); return eax; } |