summaryrefslogtreecommitdiffstats
path: root/hw/ide/macio.c
diff options
context:
space:
mode:
authorCornelia Huck2017-03-01 18:58:52 +0100
committerMichael S. Tsirkin2017-03-02 06:14:27 +0100
commit34c6bf22a8d9b60c513df151aa0a791ef53bf81d (patch)
tree588879f9c2d168f06dfa14f5c08741a3e0a584bd /hw/ide/macio.c
parentvirtio: check for vring setup in virtio_queue_empty (diff)
downloadqemu-34c6bf22a8d9b60c513df151aa0a791ef53bf81d.tar.gz
qemu-34c6bf22a8d9b60c513df151aa0a791ef53bf81d.tar.xz
qemu-34c6bf22a8d9b60c513df151aa0a791ef53bf81d.zip
virtio: guard vring access when setting notification
Switching to vring caches exposed an existing bug in virtio_queue_set_notification(): We can't access vring structures if they have not been set up yet. This may happen, for example, for virtio-blk devices with multiple queues: The code will try to switch notifiers for every queue, but the guest may have only set up a subset of them. Fix this by guarding access to the vring memory by checking for vring.desc. The first aio poll will iron out any remaining inconsistencies for later-configured queues (buggy legacy drivers). Signed-off-by: Cornelia Huck <cornelia.huck@de.ibm.com> Reviewed-by: Michael S. Tsirkin <mst@redhat.com> Signed-off-by: Michael S. Tsirkin <mst@redhat.com>
Diffstat (limited to 'hw/ide/macio.c')
0 files changed, 0 insertions, 0 deletions