diff options
| author | Markus Armbruster | 2019-08-12 07:23:50 +0200 |
|---|---|---|
| committer | Markus Armbruster | 2019-08-16 13:31:52 +0200 |
| commit | db725815985654007ade0fd53590d613fd657208 (patch) | |
| tree | e39bcf77a808fa0002cea415b2a487cf5c7eaf4b /hw/ide | |
| parent | Include qemu/queue.h slightly less (diff) | |
| download | qemu-db725815985654007ade0fd53590d613fd657208.tar.gz qemu-db725815985654007ade0fd53590d613fd657208.tar.xz qemu-db725815985654007ade0fd53590d613fd657208.zip | |
Include qemu/main-loop.h less
In my "build everything" tree, changing qemu/main-loop.h triggers a
recompile of some 5600 out of 6600 objects (not counting tests and
objects that don't depend on qemu/osdep.h). It includes block/aio.h,
which in turn includes qemu/event_notifier.h, qemu/notify.h,
qemu/processor.h, qemu/qsp.h, qemu/queue.h, qemu/thread-posix.h,
qemu/thread.h, qemu/timer.h, and a few more.
Include qemu/main-loop.h only where it's needed. Touching it now
recompiles only some 1700 objects. For block/aio.h and
qemu/event_notifier.h, these numbers drop from 5600 to 2800. For the
others, they shrink only slightly.
Signed-off-by: Markus Armbruster <armbru@redhat.com>
Message-Id: <20190812052359.30071-21-armbru@redhat.com>
Reviewed-by: Alex Bennée <alex.bennee@linaro.org>
Reviewed-by: Philippe Mathieu-Daudé <philmd@redhat.com>
Tested-by: Philippe Mathieu-Daudé <philmd@redhat.com>
Diffstat (limited to 'hw/ide')
| -rw-r--r-- | hw/ide/ahci.c | 1 | ||||
| -rw-r--r-- | hw/ide/core.c | 1 | ||||
| -rw-r--r-- | hw/ide/qdev.c | 1 |
3 files changed, 3 insertions, 0 deletions
diff --git a/hw/ide/ahci.c b/hw/ide/ahci.c index 1d5a54b29e..378c1f360f 100644 --- a/hw/ide/ahci.c +++ b/hw/ide/ahci.c @@ -28,6 +28,7 @@ #include "qemu/error-report.h" #include "qemu/log.h" +#include "qemu/main-loop.h" #include "qemu/module.h" #include "sysemu/block-backend.h" #include "sysemu/dma.h" diff --git a/hw/ide/core.c b/hw/ide/core.c index 005b4d5ef4..61cb3b26ab 100644 --- a/hw/ide/core.c +++ b/hw/ide/core.c @@ -27,6 +27,7 @@ #include "hw/isa/isa.h" #include "migration/vmstate.h" #include "qemu/error-report.h" +#include "qemu/main-loop.h" #include "qemu/timer.h" #include "sysemu/sysemu.h" #include "sysemu/blockdev.h" diff --git a/hw/ide/qdev.c b/hw/ide/qdev.c index d85c31a0ee..d30bdd70ee 100644 --- a/hw/ide/qdev.c +++ b/hw/ide/qdev.c @@ -22,6 +22,7 @@ #include "qapi/error.h" #include "qapi/qapi-types-block.h" #include "qemu/error-report.h" +#include "qemu/main-loop.h" #include "qemu/module.h" #include "hw/ide/internal.h" #include "sysemu/block-backend.h" |