diff options
| author | Philippe Mathieu-Daudé | 2020-04-22 15:31:47 +0200 |
|---|---|---|
| committer | Laurent Vivier | 2020-05-04 14:43:24 +0200 |
| commit | 1cf5ae5129a8e78b9eb2d6545bcc56a8b136eb79 (patch) | |
| tree | 13c79a0cb6524d4328c8adf3b6209618173af087 /hw/input | |
| parent | hw/i2c/pm_smbus: Remove dead assignment (diff) | |
| download | qemu-1cf5ae5129a8e78b9eb2d6545bcc56a8b136eb79.tar.gz qemu-1cf5ae5129a8e78b9eb2d6545bcc56a8b136eb79.tar.xz qemu-1cf5ae5129a8e78b9eb2d6545bcc56a8b136eb79.zip | |
hw/input/adb-kbd: Remove dead assignment
Since commit 5a1f49718 the 'olen' variable is not really
used. Remove it to fix a warning reported by Clang static
code analyzer:
CC hw/input/adb-kbd.o
hw/input/adb-kbd.c:200:5: warning: Value stored to 'olen' is never read
olen = 0;
^ ~
Fixes: 5a1f49718 (adb: add support for QKeyCode)
Reported-by: Clang Static Analyzer
Suggested-by: BALATON Zoltan <balaton@eik.bme.hu>
Acked-by: David Gibson <david@gibson.dropbear.id.au>
Signed-off-by: Philippe Mathieu-Daudé <philmd@redhat.com>
Message-Id: <20200422133152.16770-5-philmd@redhat.com>
Signed-off-by: Laurent Vivier <laurent@vivier.eu>
Diffstat (limited to 'hw/input')
| -rw-r--r-- | hw/input/adb-kbd.c | 6 |
1 files changed, 1 insertions, 5 deletions
diff --git a/hw/input/adb-kbd.c b/hw/input/adb-kbd.c index 0ba8207589..a6d5c9b7c9 100644 --- a/hw/input/adb-kbd.c +++ b/hw/input/adb-kbd.c @@ -195,9 +195,7 @@ static int adb_kbd_poll(ADBDevice *d, uint8_t *obuf) { KBDState *s = ADB_KEYBOARD(d); int keycode; - int olen; - olen = 0; if (s->count == 0) { return 0; } @@ -216,7 +214,6 @@ static int adb_kbd_poll(ADBDevice *d, uint8_t *obuf) if (keycode == 0x7f) { obuf[0] = 0x7f; obuf[1] = 0x7f; - olen = 2; } else { obuf[0] = keycode; /* NOTE: the power key key-up is the two byte sequence 0xff 0xff; @@ -224,10 +221,9 @@ static int adb_kbd_poll(ADBDevice *d, uint8_t *obuf) * byte, but choose not to bother. */ obuf[1] = 0xff; - olen = 2; } - return olen; + return 2; } static int adb_kbd_request(ADBDevice *d, uint8_t *obuf, |