diff options
| author | Dr. David Alan Gilbert | 2017-09-25 13:29:12 +0200 |
|---|---|---|
| committer | Dr. David Alan Gilbert | 2017-09-27 12:35:59 +0200 |
| commit | 44b1ff319c4781c7ab13f7e119b3114a1e6a52e2 (patch) | |
| tree | b8e8aa9c74c890808876e7a5969b69ac25c1930a /hw/intc/i8259_common.c | |
| parent | migration: disable auto-converge during bulk block migration (diff) | |
| download | qemu-44b1ff319c4781c7ab13f7e119b3114a1e6a52e2.tar.gz qemu-44b1ff319c4781c7ab13f7e119b3114a1e6a52e2.tar.xz qemu-44b1ff319c4781c7ab13f7e119b3114a1e6a52e2.zip | |
migration: pre_save return int
Modify the pre_save method on VMStateDescription to return an int
rather than void so that it potentially can fail.
Changed zillions of devices to make them return 0; the only
case I've made it return non-0 is hw/intc/s390_flic_kvm.c that already
had an error_report/return case.
Note: If you add an error exit in your pre_save you must emit
an error_report to say why.
Signed-off-by: Dr. David Alan Gilbert <dgilbert@redhat.com>
Message-Id: <20170925112917.21340-2-dgilbert@redhat.com>
Reviewed-by: Peter Xu <peterx@redhat.com>
Reviewed-by: Cornelia Huck <cohuck@redhat.com>
Reviewed-by: Juan Quintela <quintela@redhat.com>
Signed-off-by: Dr. David Alan Gilbert <dgilbert@redhat.com>
Diffstat (limited to 'hw/intc/i8259_common.c')
| -rw-r--r-- | hw/intc/i8259_common.c | 4 |
1 files changed, 3 insertions, 1 deletions
diff --git a/hw/intc/i8259_common.c b/hw/intc/i8259_common.c index c2fd563b5b..18427b459a 100644 --- a/hw/intc/i8259_common.c +++ b/hw/intc/i8259_common.c @@ -46,7 +46,7 @@ void pic_reset_common(PICCommonState *s) /* Note: ELCR is not reset */ } -static void pic_dispatch_pre_save(void *opaque) +static int pic_dispatch_pre_save(void *opaque) { PICCommonState *s = opaque; PICCommonClass *info = PIC_COMMON_GET_CLASS(s); @@ -54,6 +54,8 @@ static void pic_dispatch_pre_save(void *opaque) if (info->pre_save) { info->pre_save(s); } + + return 0; } static int pic_dispatch_post_load(void *opaque, int version_id) |