diff options
| author | Anton Nefedov | 2017-07-06 14:08:52 +0200 |
|---|---|---|
| committer | Paolo Bonzini | 2017-07-14 11:04:33 +0200 |
| commit | 3065070153ef4235659d821c0d6fa28fd0630c57 (patch) | |
| tree | fa9b9f1378874f727da8faa466946b6ca5d38f23 /hw/ipmi/ipmi_bmc_extern.c | |
| parent | char: forbid direct chardevice access for hotswap devices (diff) | |
| download | qemu-3065070153ef4235659d821c0d6fa28fd0630c57.tar.gz qemu-3065070153ef4235659d821c0d6fa28fd0630c57.tar.xz qemu-3065070153ef4235659d821c0d6fa28fd0630c57.zip | |
char: avoid chardevice direct access
frontends should avoid accessing CharDriver struct where possible
Signed-off-by: Anton Nefedov <anton.nefedov@virtuozzo.com>
Reviewed-by: Vladimir Sementsov-Ogievskiy <vsementsov@virtuozzo.com>
Reviewed-by: Marc-André Lureau <marcandre.lureau@redhat.com>
Message-Id: <1499342940-56739-6-git-send-email-anton.nefedov@virtuozzo.com>
Signed-off-by: Paolo Bonzini <pbonzini@redhat.com>
Diffstat (limited to 'hw/ipmi/ipmi_bmc_extern.c')
| -rw-r--r-- | hw/ipmi/ipmi_bmc_extern.c | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/hw/ipmi/ipmi_bmc_extern.c b/hw/ipmi/ipmi_bmc_extern.c index 182de5853c..abab3bba4f 100644 --- a/hw/ipmi/ipmi_bmc_extern.c +++ b/hw/ipmi/ipmi_bmc_extern.c @@ -447,7 +447,7 @@ static void ipmi_bmc_extern_realize(DeviceState *dev, Error **errp) { IPMIBmcExtern *ibe = IPMI_BMC_EXTERN(dev); - if (!qemu_chr_fe_get_driver(&ibe->chr)) { + if (!qemu_chr_fe_backend_connected(&ibe->chr)) { error_setg(errp, "IPMI external bmc requires chardev attribute"); return; } |