diff options
| author | Philippe Mathieu-Daudé | 2019-07-19 15:14:22 +0200 |
|---|---|---|
| committer | Laurent Vivier | 2019-08-21 10:56:19 +0200 |
| commit | 5a70b8b550a8e236fd7f696c803fc05c4cae2a54 (patch) | |
| tree | 9b779737f87a03c5bcb1c9a6fe60c0469ef04f6e /hw/ipmi/ipmi_bmc_extern.c | |
| parent | hw/dma/omap_dma: Move switch 'fall through' comment to correct place (diff) | |
| download | qemu-5a70b8b550a8e236fd7f696c803fc05c4cae2a54.tar.gz qemu-5a70b8b550a8e236fd7f696c803fc05c4cae2a54.tar.xz qemu-5a70b8b550a8e236fd7f696c803fc05c4cae2a54.zip | |
hw/ipmi: Rewrite a fall through comment
GCC9 is confused by this comment when building with CFLAG
-Wimplicit-fallthrough=2:
hw/ipmi/ipmi_bmc_extern.c: In function ‘addchar’:
hw/ipmi/ipmi_bmc_extern.c:178:12: error: this statement may fall through [-Werror=implicit-fallthrough=]
178 | ch |= 0x10;
| ~~~^~~~~~~
hw/ipmi/ipmi_bmc_extern.c:181:5: note: here
181 | default:
| ^~~~~~~
cc1: all warnings being treated as errors
make: *** [rules.mak:69: hw/ipmi/ipmi_bmc_extern.o] Error 1
Rewrite the comment using 'fall through' which is recognized by
GCC and static analyzers.
Reported-by: Stefan Weil <sw@weilnetz.de>
Signed-off-by: Philippe Mathieu-Daudé <philmd@redhat.com>
Acked-by: Corey Minyard <cminyard@mvista.com>
Message-Id: <20190719131425.10835-5-philmd@redhat.com>
Signed-off-by: Laurent Vivier <laurent@vivier.eu>
Diffstat (limited to 'hw/ipmi/ipmi_bmc_extern.c')
| -rw-r--r-- | hw/ipmi/ipmi_bmc_extern.c | 3 |
1 files changed, 1 insertions, 2 deletions
diff --git a/hw/ipmi/ipmi_bmc_extern.c b/hw/ipmi/ipmi_bmc_extern.c index 573428eca1..87da9ff99c 100644 --- a/hw/ipmi/ipmi_bmc_extern.c +++ b/hw/ipmi/ipmi_bmc_extern.c @@ -177,8 +177,7 @@ static void addchar(IPMIBmcExtern *ibe, unsigned char ch) ibe->outbuf[ibe->outlen] = VM_ESCAPE_CHAR; ibe->outlen++; ch |= 0x10; - /* No break */ - + /* fall through */ default: ibe->outbuf[ibe->outlen] = ch; ibe->outlen++; |