summaryrefslogtreecommitdiffstats
path: root/hw/isa
diff options
context:
space:
mode:
authorBernhard Beschow2022-06-03 20:50:39 +0200
committerPhilippe Mathieu-Daudé2022-06-11 11:44:50 +0200
commite3d198eed1a2f6cc34f781fb3fe5c57caa66cc7c (patch)
tree1be633d108c9459d0203441b205fd89a2e7ed58e /hw/isa
parenthw/isa/piix4: QOM'ify PCI device creation and wiring (diff)
downloadqemu-e3d198eed1a2f6cc34f781fb3fe5c57caa66cc7c.tar.gz
qemu-e3d198eed1a2f6cc34f781fb3fe5c57caa66cc7c.tar.xz
qemu-e3d198eed1a2f6cc34f781fb3fe5c57caa66cc7c.zip
hw/isa/piix4: Factor out ISABus retrieval from piix4_create()
Modernizes the code. Signed-off-by: Bernhard Beschow <shentey@gmail.com> Reviewed-by: Mark Cave-Ayland <mark.cave-ayland@ilande.co.uk> Reviewed-by: Philippe Mathieu-Daudé <f4bug@amsat.org> Message-Id: <20220603185045.143789-6-shentey@gmail.com> Signed-off-by: Philippe Mathieu-Daudé <f4bug@amsat.org>
Diffstat (limited to 'hw/isa')
-rw-r--r--hw/isa/piix4.c6
1 files changed, 1 insertions, 5 deletions
diff --git a/hw/isa/piix4.c b/hw/isa/piix4.c
index 058bebb5e2..96df21a610 100644
--- a/hw/isa/piix4.c
+++ b/hw/isa/piix4.c
@@ -312,7 +312,7 @@ static void piix4_register_types(void)
type_init(piix4_register_types)
-DeviceState *piix4_create(PCIBus *pci_bus, ISABus **isa_bus, I2CBus **smbus)
+DeviceState *piix4_create(PCIBus *pci_bus, I2CBus **smbus)
{
PCIDevice *pci;
DeviceState *dev;
@@ -322,10 +322,6 @@ DeviceState *piix4_create(PCIBus *pci_bus, ISABus **isa_bus, I2CBus **smbus)
TYPE_PIIX4_PCI_DEVICE);
dev = DEVICE(pci);
- if (isa_bus) {
- *isa_bus = ISA_BUS(qdev_get_child_bus(dev, "isa.0"));
- }
-
if (smbus) {
pci = pci_new(devfn + 3, TYPE_PIIX4_PM);
qdev_prop_set_uint32(DEVICE(pci), "smb_io_base", 0x1100);