diff options
| author | Markus Armbruster | 2019-08-12 07:23:51 +0200 |
|---|---|---|
| committer | Markus Armbruster | 2019-08-16 13:31:53 +0200 |
| commit | a27bd6c779badb8d76e4430d810ef710a1b98f4e (patch) | |
| tree | b7631b26b400537ff383b13e9e9deb299cef85b4 /hw/lm32 | |
| parent | Include qemu/main-loop.h less (diff) | |
| download | qemu-a27bd6c779badb8d76e4430d810ef710a1b98f4e.tar.gz qemu-a27bd6c779badb8d76e4430d810ef710a1b98f4e.tar.xz qemu-a27bd6c779badb8d76e4430d810ef710a1b98f4e.zip | |
Include hw/qdev-properties.h less
In my "build everything" tree, changing hw/qdev-properties.h triggers
a recompile of some 2700 out of 6600 objects (not counting tests and
objects that don't depend on qemu/osdep.h).
Many places including hw/qdev-properties.h (directly or via hw/qdev.h)
actually need only hw/qdev-core.h. Include hw/qdev-core.h there
instead.
hw/qdev.h is actually pointless: all it does is include hw/qdev-core.h
and hw/qdev-properties.h, which in turn includes hw/qdev-core.h.
Replace the remaining uses of hw/qdev.h by hw/qdev-properties.h.
While there, delete a few superfluous inclusions of hw/qdev-core.h.
Touching hw/qdev-properties.h now recompiles some 1200 objects.
Cc: Paolo Bonzini <pbonzini@redhat.com>
Cc: "Daniel P. Berrangé" <berrange@redhat.com>
Cc: Eduardo Habkost <ehabkost@redhat.com>
Signed-off-by: Markus Armbruster <armbru@redhat.com>
Reviewed-by: Eduardo Habkost <ehabkost@redhat.com>
Message-Id: <20190812052359.30071-22-armbru@redhat.com>
Diffstat (limited to 'hw/lm32')
| -rw-r--r-- | hw/lm32/lm32.h | 1 | ||||
| -rw-r--r-- | hw/lm32/milkymist-hw.h | 2 | ||||
| -rw-r--r-- | hw/lm32/milkymist.c | 1 |
3 files changed, 3 insertions, 1 deletions
diff --git a/hw/lm32/lm32.h b/hw/lm32/lm32.h index d1514a61b3..98de07acf2 100644 --- a/hw/lm32/lm32.h +++ b/hw/lm32/lm32.h @@ -2,6 +2,7 @@ #define HW_LM32_H #include "hw/char/lm32_juart.h" +#include "hw/qdev-properties.h" static inline DeviceState *lm32_pic_init(qemu_irq cpu_irq) { diff --git a/hw/lm32/milkymist-hw.h b/hw/lm32/milkymist-hw.h index 976cf9254d..5f63024355 100644 --- a/hw/lm32/milkymist-hw.h +++ b/hw/lm32/milkymist-hw.h @@ -1,7 +1,7 @@ #ifndef QEMU_HW_MILKYMIST_HW_H #define QEMU_HW_MILKYMIST_HW_H -#include "hw/qdev.h" +#include "hw/qdev-core.h" #include "net/net.h" static inline DeviceState *milkymist_uart_create(hwaddr base, diff --git a/hw/lm32/milkymist.c b/hw/lm32/milkymist.c index 5ec3ae0300..460d322de5 100644 --- a/hw/lm32/milkymist.c +++ b/hw/lm32/milkymist.c @@ -30,6 +30,7 @@ #include "sysemu/reset.h" #include "hw/boards.h" #include "hw/loader.h" +#include "hw/qdev-properties.h" #include "elf.h" #include "milkymist-hw.h" #include "hw/display/milkymist_tmu2.h" |