diff options
| author | Philippe Mathieu-Daudé | 2019-10-10 15:15:27 +0200 |
|---|---|---|
| committer | Eduardo Habkost | 2019-10-15 23:18:08 +0200 |
| commit | 88552b16f2a11a51323b8a4d643e73332d89d7ef (patch) | |
| tree | 335246dbf55f447c5b534efaa587ba7e9c2227f5 /hw/misc | |
| parent | hw/input/lm832x: Convert reset handler to DeviceReset (diff) | |
| download | qemu-88552b16f2a11a51323b8a4d643e73332d89d7ef.tar.gz qemu-88552b16f2a11a51323b8a4d643e73332d89d7ef.tar.xz qemu-88552b16f2a11a51323b8a4d643e73332d89d7ef.zip | |
hw/misc/vmcoreinfo: Add comment about reset handler
The VM coreinfo device does not sit on a bus, so it won't be
reset automatically. This is why it calls qemu_register_reset().
Add a comment about it, so we don't convert its reset handler
to a DeviceReset method.
Reviewed-by: Marc-André Lureau <marcandre.lureau@redhat.com>
Reviewed-by: Li Qiang <liq3ea@gmail.com>
Signed-off-by: Philippe Mathieu-Daudé <philmd@redhat.com>
Message-Id: <20191010131527.32513-9-philmd@redhat.com>
Signed-off-by: Eduardo Habkost <ehabkost@redhat.com>
Diffstat (limited to 'hw/misc')
| -rw-r--r-- | hw/misc/vmcoreinfo.c | 4 |
1 files changed, 4 insertions, 0 deletions
diff --git a/hw/misc/vmcoreinfo.c b/hw/misc/vmcoreinfo.c index 326a3ce8f4..a9d718fc23 100644 --- a/hw/misc/vmcoreinfo.c +++ b/hw/misc/vmcoreinfo.c @@ -61,6 +61,10 @@ static void vmcoreinfo_realize(DeviceState *dev, Error **errp) NULL, fw_cfg_vmci_write, s, &s->vmcoreinfo, sizeof(s->vmcoreinfo), false); + /* + * This device requires to register a global reset because it is + * not plugged to a bus (which, as its QOM parent, would reset it). + */ qemu_register_reset(vmcoreinfo_reset, dev); vmcoreinfo_state = s; } |