diff options
| author | Peter Maydell | 2016-06-16 19:17:24 +0200 |
|---|---|---|
| committer | Peter Maydell | 2016-06-27 17:39:56 +0200 |
| commit | 4071887b58defdb09e15359dd493475c3b2578d8 (patch) | |
| tree | 17107d74af2ad695f688f3c3bd653609ddead69f /hw/net/rocker | |
| parent | hw/net/rtl8139.c: Don't use *_to_cpup() (diff) | |
| download | qemu-4071887b58defdb09e15359dd493475c3b2578d8.tar.gz qemu-4071887b58defdb09e15359dd493475c3b2578d8.tar.xz qemu-4071887b58defdb09e15359dd493475c3b2578d8.zip | |
hw/net/rocker: Don't use *_to_cpup()
Don't use *_to_cpup() to do byte-swapped loads; instead use
ld*_p() which correctly handle misaligned accesses.
Signed-off-by: Peter Maydell <peter.maydell@linaro.org>
Reviewed-by: Richard Henderson <rth@twiddle.net>
Acked-by: Jason Wang <jasowang@redhat.com>
Acked-by: Dmitry Fleytman <dmitry@daynix.com <mailto:dmitry@daynix.com>>
Message-id: 1466097446-981-4-git-send-email-peter.maydell@linaro.org
Diffstat (limited to 'hw/net/rocker')
| -rw-r--r-- | hw/net/rocker/rocker_tlv.h | 6 |
1 files changed, 3 insertions, 3 deletions
diff --git a/hw/net/rocker/rocker_tlv.h b/hw/net/rocker/rocker_tlv.h index e3c4ab6793..88561648f0 100644 --- a/hw/net/rocker/rocker_tlv.h +++ b/hw/net/rocker/rocker_tlv.h @@ -106,17 +106,17 @@ static inline uint64_t rocker_tlv_get_u64(const RockerTlv *tlv) static inline uint16_t rocker_tlv_get_le16(const RockerTlv *tlv) { - return le16_to_cpup((uint16_t *) rocker_tlv_data(tlv)); + return lduw_le_p(rocker_tlv_data(tlv)); } static inline uint32_t rocker_tlv_get_le32(const RockerTlv *tlv) { - return le32_to_cpup((uint32_t *) rocker_tlv_data(tlv)); + return ldl_le_p(rocker_tlv_data(tlv)); } static inline uint64_t rocker_tlv_get_le64(const RockerTlv *tlv) { - return le64_to_cpup((uint64_t *) rocker_tlv_data(tlv)); + return ldq_le_p(rocker_tlv_data(tlv)); } static inline void rocker_tlv_parse(RockerTlv **tb, int maxtype, |