diff options
| author | John Snow | 2022-02-25 21:59:47 +0100 |
|---|---|---|
| committer | John Snow | 2022-03-07 20:36:41 +0100 |
| commit | 673856f9d889dc50b6a1a7964df960c4f00c7c93 (patch) | |
| tree | f2286866c6e5c624df1c8ca80ff78f7052161b34 /hw/net/virtio-net.c | |
| parent | python/aqmp: add start_server() and accept() methods (diff) | |
| download | qemu-673856f9d889dc50b6a1a7964df960c4f00c7c93.tar.gz qemu-673856f9d889dc50b6a1a7964df960c4f00c7c93.tar.xz qemu-673856f9d889dc50b6a1a7964df960c4f00c7c93.zip | |
python/aqmp: fix race condition in legacy.py
legacy.py provides a synchronous model. iotests frequently uses this
paradigm:
- create QMP client object
- start QEMU process
- await connection from QEMU process
In the switch from sync to async QMP, the QMP client object stopped
calling bind() and listen() during the QMP object creation step, which
creates a race condition if the QEMU process dials in too quickly.
With refactoring out of the way, restore the former behavior of calling
bind() and listen() during __init__() to fix this race condition.
Signed-off-by: John Snow <jsnow@redhat.com>
Acked-by: Kevin Wolf <kwolf@redhat.com>
Reviewed-by: Daniel P. Berrangé <berrange@redhat.com>
Message-id: 20220225205948.3693480-10-jsnow@redhat.com
[Expanded commit message. --js]
Signed-off-by: John Snow <jsnow@redhat.com>
Diffstat (limited to 'hw/net/virtio-net.c')
0 files changed, 0 insertions, 0 deletions