diff options
| author | Juan Quintela | 2020-11-18 09:37:34 +0100 |
|---|---|---|
| committer | Michael S. Tsirkin | 2020-12-08 19:48:57 +0100 |
| commit | 7b3dc2f8c0b817bbe78ba347130b3c99fe2c4470 (patch) | |
| tree | 145929d443a52e994f4744cc9942d59ceec13407 /hw/net/virtio-net.c | |
| parent | failover: Remove primary_device_dict (diff) | |
| download | qemu-7b3dc2f8c0b817bbe78ba347130b3c99fe2c4470.tar.gz qemu-7b3dc2f8c0b817bbe78ba347130b3c99fe2c4470.tar.xz qemu-7b3dc2f8c0b817bbe78ba347130b3c99fe2c4470.zip | |
failover: Remove memory leak
Two things, at this point:
* n->primary_device_id has to be set, otherwise
virtio_net_find_primary don't work. So we have a leak here.
* it has to be exactly the same that prim_dev->id because what
qdev_find_recursive() does is just compare this two values.
So remove the unneeded assignment and leaky bits.
Signed-off-by: Juan Quintela <quintela@redhat.com>
Message-Id: <20201118083748.1328-14-quintela@redhat.com>
Reviewed-by: Michael S. Tsirkin <mst@redhat.com>
Signed-off-by: Michael S. Tsirkin <mst@redhat.com>
Diffstat (limited to 'hw/net/virtio-net.c')
| -rw-r--r-- | hw/net/virtio-net.c | 4 |
1 files changed, 1 insertions, 3 deletions
diff --git a/hw/net/virtio-net.c b/hw/net/virtio-net.c index 6e5a56a230..70fa372c08 100644 --- a/hw/net/virtio-net.c +++ b/hw/net/virtio-net.c @@ -854,9 +854,7 @@ static DeviceState *virtio_connect_failover_devices(VirtIONet *n, Error **errp) Error *err = NULL; prim_dev = virtio_net_find_primary(n, &err); - if (prim_dev) { - n->primary_device_id = g_strdup(prim_dev->id); - } else { + if (!prim_dev) { error_propagate(errp, err); } |