diff options
| author | Peter Maydell | 2020-11-10 22:52:49 +0100 |
|---|---|---|
| committer | Jason Wang | 2020-11-11 13:34:36 +0100 |
| commit | 676ea985c0d13c9d39b9ead4c60005abb9ea4218 (patch) | |
| tree | f9b6317f2d24de711595330538bb56c231dfd951 /hw/net | |
| parent | hw/net/can/ctucan: Avoid unused value in ctucan_send_ready_buffers() (diff) | |
| download | qemu-676ea985c0d13c9d39b9ead4c60005abb9ea4218.tar.gz qemu-676ea985c0d13c9d39b9ead4c60005abb9ea4218.tar.xz qemu-676ea985c0d13c9d39b9ead4c60005abb9ea4218.zip | |
hw/net/can/ctucan_core: Handle big-endian hosts
The ctucan driver defines types for its registers which are a union
of a uint32_t with a struct with bitfields for the individual
fields within that register. This is a bad idea, because bitfields
aren't portable. The ctu_can_fd_regs.h header works around the
most glaring of the portability issues by defining the
fields in two different orders depending on the setting of the
__LITTLE_ENDIAN_BITFIELD define. However, in ctucan_core.h this
is unconditionally set to 1, which is wrong for big-endian hosts.
Set it only if HOST_WORDS_BIGENDIAN is not set. There is no need
for a "have we defined it already" guard, because the only place
that should set it is ctucan_core.h, which has the usual
double-inclusion guard.
Signed-off-by: Peter Maydell <peter.maydell@linaro.org>
Reviewed-by: Philippe Mathieu-Daudé <f4bug@amsat.org>
Acked-by: Pavel Pisa <pisa@cmp.felk.cvut.cz>
Tested-by: Pavel Pisa <pisa@cmp.felk.cvut.cz>
Signed-off-by: Jason Wang <jasowang@redhat.com>
Diffstat (limited to 'hw/net')
| -rw-r--r-- | hw/net/can/ctucan_core.h | 3 |
1 files changed, 1 insertions, 2 deletions
diff --git a/hw/net/can/ctucan_core.h b/hw/net/can/ctucan_core.h index f21cb1c5ec..bbc09ae067 100644 --- a/hw/net/can/ctucan_core.h +++ b/hw/net/can/ctucan_core.h @@ -31,8 +31,7 @@ #include "exec/hwaddr.h" #include "net/can_emu.h" - -#ifndef __LITTLE_ENDIAN_BITFIELD +#ifndef HOST_WORDS_BIGENDIAN #define __LITTLE_ENDIAN_BITFIELD 1 #endif |