diff options
| author | Philippe Mathieu-Daudé | 2022-08-19 17:39:25 +0200 |
|---|---|---|
| committer | Peter Maydell | 2022-09-22 17:38:28 +0200 |
| commit | c140a69055bad798a335ea3c83aebceaca82bde0 (patch) | |
| tree | 641be2f5894872fb4dff75f8bf1a1bda10c92b30 /hw/net | |
| parent | io/channel-websock: Replace strlen(const_str) by sizeof(const_str) - 1 (diff) | |
| download | qemu-c140a69055bad798a335ea3c83aebceaca82bde0.tar.gz qemu-c140a69055bad798a335ea3c83aebceaca82bde0.tar.xz qemu-c140a69055bad798a335ea3c83aebceaca82bde0.zip | |
hw/net/e1000e_core: Use definition to avoid dynamic stack allocation
The compiler isn't clever enough to figure 'min_buf_size'
is a constant, so help it by using a definitions instead.
Signed-off-by: Philippe Mathieu-Daudé <philmd@redhat.com>
Acked-by: Jason Wang <jasowang@redhat.com>
Reviewed-by: Richard Henderson <richard.henderson@linaro.org>
Signed-off-by: Peter Maydell <peter.maydell@linaro.org>
Message-id: 20220819153931.3147384-6-peter.maydell@linaro.org
Diffstat (limited to 'hw/net')
| -rw-r--r-- | hw/net/e1000e_core.c | 7 |
1 files changed, 4 insertions, 3 deletions
diff --git a/hw/net/e1000e_core.c b/hw/net/e1000e_core.c index 208e3e0d79..82aa61fedc 100644 --- a/hw/net/e1000e_core.c +++ b/hw/net/e1000e_core.c @@ -1622,15 +1622,16 @@ e1000e_rx_fix_l4_csum(E1000ECore *core, struct NetRxPkt *pkt) } } +/* Min. octets in an ethernet frame sans FCS */ +#define MIN_BUF_SIZE 60 + ssize_t e1000e_receive_iov(E1000ECore *core, const struct iovec *iov, int iovcnt) { static const int maximum_ethernet_hdr_len = (14 + 4); - /* Min. octets in an ethernet frame sans FCS */ - static const int min_buf_size = 60; uint32_t n = 0; - uint8_t min_buf[min_buf_size]; + uint8_t min_buf[MIN_BUF_SIZE]; struct iovec min_iov; uint8_t *filter_buf; size_t size, orig_size; |