summaryrefslogtreecommitdiffstats
path: root/hw/nvme/ctrl.c
diff options
context:
space:
mode:
authorKlaus Jensen2021-08-23 14:11:33 +0200
committerKlaus Jensen2021-09-24 08:31:35 +0200
commitfd761337aca5b55c133c3bec1b8bd4471cb9571a (patch)
tree3ca7dd5bc1a920c4650392034c88f1c30797057b /hw/nvme/ctrl.c
parentMerge remote-tracking branch 'remotes/alistair23/tags/pull-riscv-to-apply-202... (diff)
downloadqemu-fd761337aca5b55c133c3bec1b8bd4471cb9571a.tar.gz
qemu-fd761337aca5b55c133c3bec1b8bd4471cb9571a.tar.xz
qemu-fd761337aca5b55c133c3bec1b8bd4471cb9571a.zip
hw/nvme: fix validation of ASQ and ACQ
Address 0x0 is a valid address. Fix the admin submission and completion queue address validation to not error out on this. Signed-off-by: Klaus Jensen <k.jensen@samsung.com> Reviewed-by: Keith Busch <kbusch@kernel.org>
Diffstat (limited to 'hw/nvme/ctrl.c')
-rw-r--r--hw/nvme/ctrl.c8
1 files changed, 0 insertions, 8 deletions
diff --git a/hw/nvme/ctrl.c b/hw/nvme/ctrl.c
index 6baf9e0420..ff78485113 100644
--- a/hw/nvme/ctrl.c
+++ b/hw/nvme/ctrl.c
@@ -5623,14 +5623,6 @@ static int nvme_start_ctrl(NvmeCtrl *n)
trace_pci_nvme_err_startfail_sq();
return -1;
}
- if (unlikely(!asq)) {
- trace_pci_nvme_err_startfail_nbarasq();
- return -1;
- }
- if (unlikely(!acq)) {
- trace_pci_nvme_err_startfail_nbaracq();
- return -1;
- }
if (unlikely(asq & (page_size - 1))) {
trace_pci_nvme_err_startfail_asq_misaligned(asq);
return -1;