diff options
author | Eduardo Habkost | 2017-07-07 23:30:52 +0200 |
---|---|---|
committer | Eduardo Habkost | 2017-07-17 20:41:30 +0200 |
commit | ebcc479eee740937e70a94a468effcf2126a572b (patch) | |
tree | 3fb4ce93038948443293e50387165d229483ae7b /hw/nvram | |
parent | Revert "machine: Convert abstract typename on compat_props to subclass names" (diff) | |
download | qemu-ebcc479eee740937e70a94a468effcf2126a572b.tar.gz qemu-ebcc479eee740937e70a94a468effcf2126a572b.tar.xz qemu-ebcc479eee740937e70a94a468effcf2126a572b.zip |
qom: Fix ambiguous path detection when ambiguous=NULL
object_resolve_path*() ambiguous path detection breaks when
ambiguous==NULL and the object tree have 3 objects of the same type and
only 2 of them are under the same parent. e.g.:
/container/obj1 (TYPE_FOO)
/container/obj2 (TYPE_FOO)
/obj2 (TYPE_FOO)
With the above tree, object_resolve_path_type("", TYPE_FOO, NULL) will
incorrectly return /obj2, because the search inside "/container" will
return NULL, and the match at "/obj2" won't be detected as ambiguous.
Fix that by always calling object_resolve_partial_path() with a non-NULL
ambiguous parameter.
Test case included.
Reported-by: Igor Mammedov <imammedo@redhat.com>
Cc: Mark Cave-Ayland <mark.cave-ayland@ilande.co.uk>
Signed-off-by: Eduardo Habkost <ehabkost@redhat.com>
Message-Id: <20170707213052.13087-3-ehabkost@redhat.com>
Signed-off-by: Eduardo Habkost <ehabkost@redhat.com>
Diffstat (limited to 'hw/nvram')
0 files changed, 0 insertions, 0 deletions