diff options
| author | David Gibson | 2019-04-24 06:19:58 +0200 |
|---|---|---|
| committer | Michael S. Tsirkin | 2019-05-21 00:40:02 +0200 |
| commit | b0e5196a52248d7e4eef709481c1c530c1bca6df (patch) | |
| tree | 6008b4126f8c073bf311599a4b7ea99fbf650dbf /hw/pci-bridge | |
| parent | pcie: Remove redundant test in pcie_mmcfg_data_{read,write}() (diff) | |
| download | qemu-b0e5196a52248d7e4eef709481c1c530c1bca6df.tar.gz qemu-b0e5196a52248d7e4eef709481c1c530c1bca6df.tar.xz qemu-b0e5196a52248d7e4eef709481c1c530c1bca6df.zip | |
pci: Simplify pci_bus_is_root()
pci_bus_is_root() currently relies on a method in the PCIBusClass.
But it's always known if a PCI bus is a root bus when we create it, so
using a dynamic method is overkill.
This replaces it with an IS_ROOT bit in a new flags field, which is set on
root buses and otherwise clear. As a bonus this removes the special
is_root logic from pci_expander_bridge, since it already creates its bus
as a root bus.
Signed-off-by: David Gibson <david@gibson.dropbear.id.au>
Reviewed-by: Marcel Apfelbaum <marcel@redhat.com>
Reviewed-by: Peter Xu <peterx@redhat.com>
Reviewed-by: Greg Kurz <groug@kaod.org>
Message-Id: <20190424041959.4087-3-david@gibson.dropbear.id.au>
Diffstat (limited to 'hw/pci-bridge')
| -rw-r--r-- | hw/pci-bridge/pci_expander_bridge.c | 6 |
1 files changed, 0 insertions, 6 deletions
diff --git a/hw/pci-bridge/pci_expander_bridge.c b/hw/pci-bridge/pci_expander_bridge.c index e62de4218f..ca66bc721a 100644 --- a/hw/pci-bridge/pci_expander_bridge.c +++ b/hw/pci-bridge/pci_expander_bridge.c @@ -66,11 +66,6 @@ static int pxb_bus_num(PCIBus *bus) return pxb->bus_nr; } -static bool pxb_is_root(PCIBus *bus) -{ - return true; /* by definition */ -} - static uint16_t pxb_bus_numa_node(PCIBus *bus) { PXBDev *pxb = convert_to_pxb(bus->parent_dev); @@ -83,7 +78,6 @@ static void pxb_bus_class_init(ObjectClass *class, void *data) PCIBusClass *pbc = PCI_BUS_CLASS(class); pbc->bus_num = pxb_bus_num; - pbc->is_root = pxb_is_root; pbc->numa_node = pxb_bus_numa_node; } |